Bug 196469 - [WebCore] Put more things into IsoHeap
Summary: [WebCore] Put more things into IsoHeap
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-01 15:29 PDT by Yusuke Suzuki
Modified: 2019-04-11 11:19 PDT (History)
1 user (show)

See Also:


Attachments
Patch (7.16 KB, patch)
2019-04-11 11:18 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-04-01 15:29:50 PDT
...
Comment 1 Yusuke Suzuki 2019-04-01 16:19:29 PDT
I've hacked lldb_webkit to dump all the classes which are,

1. Derived class of ScriptWrappable
2. Not in IsoHeap

The results are following.

WebCore::CanvasRenderingContext
WebCore::WebGLRenderingContextBase
WebCore::OffscreenCanvas
WebCore::ImageBitmap
WebCore::GPUBasedCanvasRenderingContext
WebCore::TypedOMCSSImageValue
WebCore::File
WebCore::EventTarget
WebCore::MessagePort
WebCore::DOMWindow
WebCore::DOMImplementation
WebCore::NodeIterator
WebCore::LiveNodeList
WebCore::HTMLCollection
WebCore::Event
WebCore::Worklet
WebCore::PaintWorkletGlobalScope
WebCore::CSSStyleDeclaration
WebCore::Location
WebCore::SecurityPolicyViolationEvent
WebCore::ServiceWorker
WebCore::ServiceWorkerContainer
WebCore::NamedNodeMap
WebCore::KeyboardEvent
WebCore::DatasetDOMStringMap
WebCore::PropertySetCSSStyleDeclaration
WebCore::TextTrack
WebCore::EventTargetWithInlineData
WebCore::TextTrackCue
WebCore::MediaSource
WebCore::TextTrackList
WebCore::AudioTrackList
WebCore::VideoTrackList
WebCore::MediaElementAudioSourceNode
WebCore::MediaController
WebCore::Blob
WebCore::MediaStream
WebCore::SourceBuffer
WebCore::TrackListBase
WebCore::RTCPeerConnection
WebCore::DataCue
WebCore::MouseEvent
WebCore::UIEvent
WebCore::MouseRelatedEvent
WebCore::UIEventWithKeyState
WebCore::AbstractDOMWindow
WebCore::GamepadEvent
WebCore::Navigator
WebCore::History
WebCore::BarProp
WebCore::Screen
WebCore::VisualViewport
WebCore::Storage
WebCore::DOMApplicationCache
WebCore::Performance
WebCore::FileList
WebCore::BeforeTextInsertedEvent
WebCore::InbandDataTextTrack
WebCore::InbandTextTrack
WebCore::VTTCue
WebCore::TextTrackCueGeneric
WebCore::InbandGenericTextTrack
WebCore::InbandWebVTTTextTrack
WebCore::RTCDataChannel
WebCore::RTCDataChannelEvent
WebCore::MediaStreamTrack
WebCore::RTCSessionDescription
WebCore::RTCRtpReceiver
WebCore::RTCRtpTransceiver
WebCore::RTCRtpSender
WebCore::RTCIceTransport
WebCore::RTCIceCandidate
WebCore::RTCTrackEvent
WebCore::LoadableTextTrack
WebCore::MediaEncryptedEvent
WebCore::MediaKeyMessageEvent
WebCore::MediaKeySession
WebCore::DOMMimeTypeArray
WebCore::DOMPluginArray
WebCore::WebGLRenderingContext
WebCore::TrackEvent
WebCore::AbortController
WebCore::AbortSignal
WebCore::ProgressValueElement
WebCore::SourceBufferList
WebCore::AccessibleSetValueEvent
WebCore::AnimationEvent
WebCore::AnimationPlaybackEvent
WebCore::ApplePayPaymentAuthorizedEvent
WebCore::ApplePayPaymentMethodSelectedEvent
WebCore::ApplePayShippingContactSelectedEvent
WebCore::ApplePayShippingMethodSelectedEvent
WebCore::ApplePayValidateMerchantEvent
WebCore::AudioProcessingEvent
WebCore::BeforeLoadEvent
WebCore::BeforeUnloadEvent
WebCore::BlobEvent
WebCore::ClipboardEvent
WebCore::CloseEvent
WebCore::CompositionEvent
WebCore::CustomEvent
WebCore::ErrorEvent
WebCore::ExtendableEvent
WebCore::WorkerGlobalScope
WebCore::ServiceWorkerGlobalScope
WebCore::ExtendableMessageEvent
WebCore::FetchEvent
WebCore::FocusEvent
WebCore::GestureEvent
WebCore::HashChangeEvent
WebCore::IDBVersionChangeEvent
WebCore::InputEvent
WebCore::MediaRecorderErrorEvent
WebCore::MediaStreamTrackEvent
WebCore::MerchantValidationEvent
WebCore::MessageEvent
WebCore::MutationEvent
WebCore::OfflineAudioCompletionEvent
WebCore::OverconstrainedErrorEvent
WebCore::OverflowEvent
WebCore::PageTransitionEvent
WebCore::PaymentRequestUpdateEvent
WebCore::PaymentMethodChangeEvent
WebCore::PointerEvent
WebCore::PopStateEvent
WebCore::ProgressEvent
WebCore::PromiseRejectionEvent
WebCore::RTCPeerConnectionIceEvent
WebCore::SVGZoomEvent
WebCore::SpeechSynthesisEvent
WebCore::StorageEvent
WebCore::TextEvent
WebCore::TransitionEvent
WebCore::VRDisplay
WebCore::VRDisplayEvent
WebCore::WebGLContextEvent
WebCore::WebKitAnimationEvent
WebCore::WebKitMediaKeyMessageEvent
WebCore::WebKitMediaKeyNeededEvent
WebCore::WebKitPlaybackTargetAvailabilityEvent
WebCore::WebKitTransitionEvent
WebCore::WheelEvent
WebCore::XMLHttpRequestProgressEvent
WebCore::GPUCanvasContext
WebCore::ImageBitmapRenderingContext
WebCore::CanvasRenderingContext2D
WebCore::FontFaceSet
WebCore::IDBCursor
WebCore::IDBDatabase
WebCore::IDBOpenDBRequest
WebCore::IDBRequest
WebCore::IDBKeyRange
WebCore::IDBTransaction
WebCore::ServiceWorkerRegistration
WebCore::NodeList
WebCore::AnalyserNode
WebCore::AudioBasicInspectorNode
WebCore::AudioContext
WebCore::AudioNode
WebCore::WebAnimation
WebCore::PannerNode
WebCore::AudioBufferSourceNode
WebCore::AudioScheduledSourceNode
WebCore::ConvolverNode
WebCore::DynamicsCompressorNode
WebCore::ScriptProcessorNode
WebCore::ChannelSplitterNode
WebCore::ChannelMergerNode
WebCore::OscillatorNode
WebCore::MediaStreamAudioSourceNode
WebCore::MediaStreamAudioDestinationNode
WebCore::GainNode
WebCore::BiquadFilterNode
WebCore::AudioBasicProcessorNode
WebCore::WaveShaperNode
WebCore::DelayNode
WebCore::AudioDestinationNode
WebCore::DataTransferItemList
WebCore::CSSAnimation
WebCore::StyleRuleCSSStyleDeclaration
WebCore::DeclarativeAnimation
WebCore::CanvasRenderingContext2DBase
WebCore::PaintRenderingContext2D
WebCore::CSSTransition
WebCore::CanvasCaptureMediaStreamTrack
WebCore::DOMMatrixReadOnly
WebCore::DOMMatrix
WebCore::TypedOMCSSStyleValue
WebCore::DOMPoint
WebCore::DOMPointReadOnly
WebCore::DOMFileSystem
WebCore::FileSystemEntry
WebCore::FileSystemDirectoryEntry
WebCore::FileSystemFileEntry
WebCore::DOMPlugin
WebCore::DOMRectReadOnly
WebCore::DOMQuad
WebCore::DOMRect
WebCore::HTMLOptionsCollection
WebCore::HTMLFormControlsCollection
WebCore::CachedLiveNodeList<WebCore::RadioNodeList>
WebCore::CachedHTMLCollection<WebCore::HTMLOptionsCollection, WebCore::CollectionTraversalType::Descendants>
WebCore::SpeechSynthesisUtterance
WebCore::CachedHTMLCollection<WebCore::HTMLFormControlsCollection, WebCore::CollectionTraversalType::CustomForwardOnly>
WebCore::TreeWalker
WebCore::RadioNodeList
WebCore::DedicatedWorkerGlobalScope
WebCore::WebGL2RenderingContext
WebCore::EventSource
WebCore::FileSystemDirectoryReader
WebCore::FileReader
WebCore::HTMLAllCollection
WebCore::CachedHTMLCollection<WebCore::AllDescendantsCollection, WebCore::CollectionTraversalType::Descendants>
WebCore::Geolocation
WebCore::AllDescendantsCollection
WebCore::IDBCursorWithValue
WebCore::MediaDeviceInfo
WebCore::MediaDevices
WebCore::MediaRecorder
WebCore::OfflineAudioContext
WebCore::OffscreenCanvasRenderingContext2D
WebCore::WorkletGlobalScope
WebCore::PaymentResponse
WebCore::PaymentRequest
WebCore::RemoteDOMWindow
WebCore::SVGFEFuncAElement
WebCore::SVGFEFuncBElement
WebCore::SVGFEFuncGElement
WebCore::SVGFEFuncRElement
WebCore::SVGFEPointLightElement
WebCore::SVGFESpotLightElement
WebCore::SVGFEDistantLightElement
WebCore::TypedOMCSSNumericValue
WebCore::TypedOMCSSUnparsedValue
WebCore::TypedOMCSSUnitValue
WebCore::WebKitCSSMatrix
WebCore::WebSocket
WebCore::WebKitMediaKeySession
WebCore::Worker
WebCore::AbstractWorker
WebCore::XMLHttpRequest
WebCore::XMLHttpRequestEventTarget
WebCore::XMLHttpRequestUpload
WebCore::ApplePaySession
WebCore::IDBRequestCompletionEvent
WebCore::OfflineAudioDestinationNode
WebCore::DefaultAudioDestinationNode
WebCore::ChildNodeList
WebCore::EmptyNodeList
WebCore::CSSComputedStyleDeclaration
WebCore::InlineCSSStyleDeclaration
WebCore::TagCollectionNS
WebCore::CachedHTMLCollection<WebCore::TagCollectionNS, WebCore::CollectionTraversalType::Descendants>
WebCore::StaticNodeList
WebCore::CachedHTMLCollection<WebCore::ClassCollection, WebCore::CollectionTraversalType::Descendants>
WebCore::ClassCollection
WebCore::GenericCachedHTMLCollection<WebCore::CollectionTraversalType::ChildrenOnly>
WebCore::CachedHTMLCollection<WebCore::GenericCachedHTMLCollection<WebCore::CollectionTraversalType::ChildrenOnly>, WebCore::CollectionTraversalType::ChildrenOnly>
WebCore::CachedLiveNodeList<WebCore::NameNodeList>
WebCore::TagCollection
WebCore::NameNodeList
WebCore::HTMLTagCollection
WebCore::CachedHTMLCollection<WebCore::HTMLTagCollection, WebCore::CollectionTraversalType::Descendants>
WebCore::CachedHTMLCollection<WebCore::TagCollection, WebCore::CollectionTraversalType::Descendants>
WebCore::DeviceMotionEvent
WebCore::CachedHTMLCollection<WebCore::DocumentNameCollection, WebCore::CollectionTraversalType::Descendants>
WebCore::DocumentNameCollection
WebCore::HTMLNameCollection<WebCore::DocumentNameCollection, WebCore::CollectionTraversalType::Descendants>
WebCore::HTMLAllNamedSubCollection
WebCore::CachedHTMLCollection<WebCore::HTMLAllNamedSubCollection, WebCore::CollectionTraversalType::Descendants>
WebCore::GenericCachedHTMLCollection<WebCore::CollectionTraversalType::Descendants>
WebCore::CachedHTMLCollection<WebCore::GenericCachedHTMLCollection<WebCore::CollectionTraversalType::Descendants>, WebCore::CollectionTraversalType::Descendants>
WebCore::DeviceOrientationEvent
WebCore::WindowNameCollection
WebCore::HTMLNameCollection<WebCore::WindowNameCollection, WebCore::CollectionTraversalType::Descendants>
WebCore::CachedHTMLCollection<WebCore::WindowNameCollection, WebCore::CollectionTraversalType::Descendants>
WebCore::StaticElementList
WebCore::SimulatedMouseEvent
WebCore::ProgressInnerElement
WebCore::ProgressBarElement
WebCore::CachedHTMLCollection<WebCore::HTMLTableRowsCollection, WebCore::CollectionTraversalType::CustomForwardOnly>
WebCore::HTMLTableRowsCollection
WebCore::CachedLiveNodeList<WebCore::LabelsNodeList>
WebCore::LabelsNodeList
WebCore::PlaceholderRenderingContext
Comment 2 Yusuke Suzuki 2019-04-11 11:18:00 PDT
Created attachment 367229 [details]
Patch
Comment 3 EWS Watchlist 2019-04-11 11:19:22 PDT
Attachment 367229 [details] did not pass style-queue:


ERROR: Tools/lldb/lldb_dump_class_layout.py:456:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.