Bug 196453 - Web Inspector: DOMDebugger: disabling a breakpoint for a specific event listener removes it from the UI
Summary: Web Inspector: DOMDebugger: disabling a breakpoint for a specific event liste...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-01 12:23 PDT by Devin Rousso
Modified: 2019-04-01 16:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.69 KB, patch)
2019-04-01 14:36 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-01 12:23:02 PDT 
If I set a breakpoint on a specific node's event listener for a specific event, disabling that breakpoint shouldn't delete the UI in the Debugger/Sources tab.
Comment 1 Radar WebKit Bug Importer 2019-04-01 12:23:17 PDT Comment hidden (obsolete)
Comment 2 Radar WebKit Bug Importer 2019-04-01 12:23:19 PDT 
<rdar://problem/49489318>
Comment 3 Devin Rousso 2019-04-01 14:36:43 PDT 
Created attachment 366423 [details]
Patch
Comment 4 Joseph Pecoraro 2019-04-01 16:10:55 PDT 
Comment on attachment 366423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366423&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:309
> +            WI.domManager.removeEventListenerBreakpointsForNode(domNode);

Nice!
Comment 5 WebKit Commit Bot 2019-04-01 16:38:50 PDT 
Comment on attachment 366423 [details]
Patch

Clearing flags on attachment: 366423

Committed r243722: <https://trac.webkit.org/changeset/243722>
Comment 6 WebKit Commit Bot 2019-04-01 16:38:52 PDT 
All reviewed patches have been landed.  Closing bug.