Bug 196448 – [ Mac Debug ] Layout Test inspector/audit/basic.html is a flaky timeout on bots

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Shawn Roberts]

The following layout test is flaky on Mac Debug

inspector/audit/basic.html

Probable cause:

Test was added in https://trac.webkit.org/changeset/237613/webkit , changed in https://trac.webkit.org/changeset/238850/webkit and https://trac.webkit.org/changeset/239646/webkit

Unable to reproduce locally with 1000 iterations in Mojave Debug WK2 or WK1. However it's a flaky time out in its entire available dashboard history, and appears to be timing out more frequently on Mojave Debug WK2, nearly one in every 3 runs starting around 3/23/19.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Faudit%2Fbasic.html

[Radar WebKit Bug Importer]

<rdar://problem/49485452>

[Shawn Roberts]

Marked flaky in https://trac.webkit.org/changeset/243745/webkit while waiting for a fix.

[Devin Rousso]

Created attachment 369698 [details]
Patch

[Devin Rousso]

Comment on attachment 369698 [details]
Patch

I'm not actually sure if this works (e.g. stops timing out), but I think that the underlying issue only affects a specific part of the test.  Splitting it into separate tests will either resolve the problem (in the case that it was just too long) or will allow me to understand which specific part is the issue.

[WebKit Commit Bot]

Comment on attachment 369698 [details]
Patch

Clearing flags on attachment: 369698

Committed r245257: <https://trac.webkit.org/changeset/245257>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.