Bug 196445 - [ Mac Debug ] REGRESSION (r242975) Layout Test storage/indexeddb/modern/deletedatabase-2-private.html is a flaky failure
Summary: [ Mac Debug ] REGRESSION (r242975) Layout Test storage/indexeddb/modern/delet...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-01 10:16 PDT by Shawn Roberts
Modified: 2019-05-14 15:56 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Roberts 2019-04-01 10:16:03 PDT
The following layout test is flaky on Mac WK2 Debug

storage/indexeddb/modern/deletedatabase-2-private.html

Probable cause:

After changes made in https://trac.webkit.org/changeset/242975/webkit 

Test started to become a flaky failure on Mac Debug builds. It has shown up once on the iOS Simulator Release queue, and I could reproduce it locally, but only about 1 in 1000 iterations.

With Mac Debug it is failing on average 10 in 500 iterations, and I cannot get it to fail in r242974 or older.

Reproduced with:

run-webkit-tests storage/indexeddb/modern/deletedatabase-2-private.html --iterations 500 -f --debug

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fmodern%2Fdeletedatabase-2-private.html

Diff:

--- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/storage/indexeddb/modern/deletedatabase-2-private-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/storage/indexeddb/modern/deletedatabase-2-private-actual.txt
@@ -11,9 +11,9 @@
 Requesting deleteDatabase
 First connection received versionchange event: oldVersion 1, newVersion null
 First version change complete
-Open request error: AbortError
 Delete database success: oldVersion 1, newVersion null
 Recreating database to make sure it's new and empty
+Open request error: AbortError
 Second upgrade old version - 0 new version - 1
 Unable to get object store in second upgrade transaction (which is correct because it should not be there)
 Second database upgrade success
Comment 1 Radar WebKit Bug Importer 2019-04-01 10:16:43 PDT
<rdar://problem/49483061>
Comment 2 Shawn Roberts 2019-04-01 10:23:05 PDT
Marked flaky in https://trac.webkit.org/changeset/243696/webkit while waiting for a fix.
Comment 3 Shawn Roberts 2019-05-14 15:56:06 PDT
When marking test as flaky in r243696 I did so on iOS, not on Mac.

Updated expectations properly in https://trac.webkit.org/changeset/245315/webkit