Bug 196443 - Update the status of ResizeObserver in features.json
Summary: Update the status of ResizeObserver in features.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: cathiechen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-01 07:57 PDT by cathiechen
Modified: 2019-04-02 04:00 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2019-04-01 08:07 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (1.64 KB, patch)
2019-04-01 20:43 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (1.63 KB, patch)
2019-04-02 03:20 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description cathiechen 2019-04-01 07:57:40 PDT 
Update the status of ResizeObserver in features.json
Comment 1 cathiechen 2019-04-01 08:07:50 PDT 
Created attachment 366395 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2019-04-01 12:49:29 PDT 
Comment on attachment 366395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366395&action=review

Some nitpicks.

> Source/WebCore/features.json:1139
> +            "status": "Partially Supported"

Nit: Maybe I'd say "In Development" as it's still behind build and runtime flags.
Alos you could add: "enabled-by-default": false

> Source/WebCore/features.json:1141
> +        "url": "https://wicg.github.io/ResizeObserver/",

Nit: I believe this should be now https://drafts.csswg.org/resize-observer/

> Source/WebCore/features.json:1144
> +        "description": "An API for observing changes to Elementâs size.",

I see a weird character here between "Element" and "size".
Comment 3 cathiechen 2019-04-01 20:43:55 PDT 
Created attachment 366468 [details]
Patch
Comment 4 cathiechen 2019-04-01 20:44:18 PDT 
Comment on attachment 366395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366395&action=review

Done! Thanks:)

>> Source/WebCore/features.json:1139
>> +            "status": "Partially Supported"
> 
> Nit: Maybe I'd say "In Development" as it's still behind build and runtime flags.
> Alos you could add: "enabled-by-default": false

Done

>> Source/WebCore/features.json:1141
>> +        "url": "https://wicg.github.io/ResizeObserver/",
> 
> Nit: I believe this should be now https://drafts.csswg.org/resize-observer/

Done

>> Source/WebCore/features.json:1144
>> +        "description": "An API for observing changes to Elementâs size.",
> 
> I see a weird character here between "Element" and "size".

Done
Comment 5 Manuel Rego Casasnovas 2019-04-02 03:15:46 PDT 
Comment on attachment 366468 [details]
Patch

Thanks for updating features.json!

BTW, you could have uploaded the 2nd version of the patch with "Reviewed by Rob Buis" already filled in the ChangeLog (anyway it's not a big deal in this case).
Comment 6 cathiechen 2019-04-02 03:20:21 PDT 
Created attachment 366480 [details]
Patch
Comment 7 cathiechen 2019-04-02 03:21:25 PDT 
(In reply to Manuel Rego Casasnovas from comment #5)
> Comment on attachment 366468 [details]
> Patch
> 
> Thanks for updating features.json!
> 
> BTW, you could have uploaded the 2nd version of the patch with "Reviewed by
> Rob Buis" already filled in the ChangeLog (anyway it's not a big deal in
> this case).

Done! Thanks :)
Comment 8 WebKit Commit Bot 2019-04-02 03:59:07 PDT 
Comment on attachment 366480 [details]
Patch

Clearing flags on attachment: 366480

Committed r243739: <https://trac.webkit.org/changeset/243739>
Comment 9 WebKit Commit Bot 2019-04-02 03:59:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-04-02 04:00:26 PDT 
<rdar://problem/49515062>