Disabling video causes a build failure after "Delete WebMetal implementation in favor of WebGPU": commit 2387e41376c396976e8f6950a7dfbbaa7713bf52 Author: mmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Fri Mar 29 22:18:59 2019 +0000 Delete WebMetal implementation in favor of WebGPU https://bugs.webkit.org/show_bug.cgi?id=195418 Reviewed by Dean Jackson. cmake -G Ninja -DPORT=WPE -DCMAKE_BUILD_TYPE=Release ... -DENABLE_VIDEO=OFF -DENABLE_VIDEO_TRACK=OFF -DENABLE_WEB_AUDIO=OFF:: In file included from /git/Source/WebCore/platform/Timer.h:37, from /git/Source/WebCore/platform/GenericTaskQueue.h:28, from /git/Source/WebCore/dom/Document.h:41, from /git/Source/WebCore/html/parser/XSSAuditor.cpp:32, from DerivedSources/WebCore/unified-sources/UnifiedSource-950a39b6-25.cpp:1: DerivedSources/ForwardingHeaders/wtf/WeakPtr.h: In instantiation of 'WTF::WeakPtr<T> WTF::makeWeakPtr(T&) [with T = WebCore::HTMLInputElement]': /git/Source/WebCore/html/InputType.h:318:40: required from here DerivedSources/ForwardingHeaders/wtf/WeakPtr.h:183:55: error: invalid use of incomplete type 'class WebCore::HTMLInputElement' return { adoptRef(*weak_reference_downcast<T>(ref.weakPtrFactory().createWeakPtr(ref).m_ref.leakRef())) }; ~~~~^~~~~~~~~~~~~~ In file included from /git/Source/WebCore/html/HTMLElement.h:174, from /git/Source/WebCore/html/HTMLParamElement.h:25, from /git/Source/WebCore/html/parser/XSSAuditor.cpp:39, from DerivedSources/WebCore/unified-sources/UnifiedSource-950a39b6-25.cpp:1: DerivedSources/WebCore/HTMLElementTypeHelpers.h:400:7: note: forward declaration of 'class WebCore::HTMLInputElement' class HTMLInputElement;
Created attachment 366376 [details] patch
Comment on attachment 366376 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=366376&action=review > Source/WebCore/html/InputType.h:35 > +#include "HTMLInputElement.h" There's a forward declaration of HTMLInputElement on line 58/59. You should remove that if you're going to include the full header.
Created attachment 366393 [details] patch
(In reply to David Quesada from comment #2) > Comment on attachment 366376 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366376&action=review > > > Source/WebCore/html/InputType.h:35 > > +#include "HTMLInputElement.h" > > There's a forward declaration of HTMLInputElement on line 58/59. You should > remove that if you're going to include the full header. +1
(In reply to Pablo Saavedra from comment #4) > (In reply to David Quesada from comment #2) > > Comment on attachment 366376 [details] > > patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=366376&action=review > > > > > Source/WebCore/html/InputType.h:35 > > > +#include "HTMLInputElement.h" > > > > There's a forward declaration of HTMLInputElement on line 58/59. You should > > remove that if you're going to include the full header. > > +1 I've fixed what you suggest. WDYT, does it look good, now?
Created attachment 366583 [details] patch
Created attachment 366584 [details] patch
Comment on attachment 366584 [details] patch Rejecting attachment 366584 [details] from commit-queue. psaavedra@igalia.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 366584 [details] patch Clearing flags on attachment: 366584 Committed r243799: <https://trac.webkit.org/changeset/243799>
All reviewed patches have been landed. Closing bug.