Bug 196433 – [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document

[Andy Estes]

rdar://problem/49293305

[Andy Estes]

Created attachment 366372 [details]
Patch

[Andy Estes]

Created attachment 366373 [details]
Patch

[Andy Estes]

Created attachment 366374 [details]
Patch

[Alex Christensen]

Comment on attachment 366374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366374&action=review

> Source/WTF/wtf/NeverDestroyed.h:63
> +    T* operator->() { return storagePointer(); }

The world will never be the same.

[Andy Estes]

Created attachment 366375 [details]
Patch

[Tim Horton]

Comment on attachment 366374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366374&action=review

> Source/WebCore/platform/network/ios/PreviewConverter.mm:59
> +    if (equalLettersIgnoringASCIICase(mimeType, "text/html") || equalLettersIgnoringASCIICase(mimeType, "text/plain"))

Surprised we don't have constants for these but it seems like we don't.

> Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp:41
> +    EXPECT_FALSE(PreviewConverter::supportsMIMEType(String()));
> +    EXPECT_FALSE(PreviewConverter::supportsMIMEType(emptyString()));

Maybe cover at least one non-empty/null falsy one?

[Andy Estes]

Created attachment 366377 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 366377 [details]
Patch

Clearing flags on attachment: 366377

Committed r243682: <https://trac.webkit.org/changeset/243682>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.