Bug 196433 - [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
Summary: [iOS] WebKit should consult the navigation response policy delegate before pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks: 202935
  Show dependency tree / graph
 
Reported: 2019-03-30 21:18 PDT by Andy Estes
Modified: 2019-10-14 10:40 PDT (History)
18 users (show)

See Also:

Attachments
Patch (62.35 KB, patch)
2019-03-30 21:22 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (64.11 KB, patch)
2019-03-30 21:42 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (64.29 KB, patch)
2019-03-30 22:08 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (64.21 KB, patch)
2019-03-30 23:59 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (64.20 KB, patch)
2019-03-31 09:57 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-03-30 21:18:34 PDT 
[iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
Comment 1 Andy Estes 2019-03-30 21:19:43 PDT 
rdar://problem/49293305
Comment 2 Andy Estes 2019-03-30 21:22:59 PDT Comment hidden (obsolete)
Comment 3 Andy Estes 2019-03-30 21:42:35 PDT Comment hidden (obsolete)
Comment 4 Andy Estes 2019-03-30 22:08:52 PDT Comment hidden (obsolete)
Comment 5 Alex Christensen 2019-03-30 22:09:38 PDT 
Comment on attachment 366374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366374&action=review

> Source/WTF/wtf/NeverDestroyed.h:63
> +    T* operator->() { return storagePointer(); }

The world will never be the same.
Comment 6 Andy Estes 2019-03-30 23:59:10 PDT Comment hidden (obsolete)
Comment 7 Tim Horton 2019-03-31 00:06:00 PDT 
Comment on attachment 366374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366374&action=review

> Source/WebCore/platform/network/ios/PreviewConverter.mm:59
> +    if (equalLettersIgnoringASCIICase(mimeType, "text/html") || equalLettersIgnoringASCIICase(mimeType, "text/plain"))

Surprised we don't have constants for these but it seems like we don't.

> Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp:41
> +    EXPECT_FALSE(PreviewConverter::supportsMIMEType(String()));
> +    EXPECT_FALSE(PreviewConverter::supportsMIMEType(emptyString()));

Maybe cover at least one non-empty/null falsy one?
Comment 8 Andy Estes 2019-03-31 09:57:53 PDT 
Created attachment 366377 [details]
Patch
Comment 9 WebKit Commit Bot 2019-03-31 10:37:51 PDT 
Comment on attachment 366377 [details]
Patch

Clearing flags on attachment: 366377

Committed r243682: <https://trac.webkit.org/changeset/243682>
Comment 10 WebKit Commit Bot 2019-03-31 10:37:53 PDT 
All reviewed patches have been landed.  Closing bug.