Bug 196425 - [JSC] JSRunLoopTimer::Manager should be small
Summary: [JSC] JSRunLoopTimer::Manager should be small
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-29 21:50 PDT by Yusuke Suzuki
Modified: 2019-04-01 11:35 PDT (History)
8 users (show)

See Also:

Attachments
Patch (12.65 KB, patch)
2019-03-29 21:50 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-highsierra (2.52 MB, application/zip)
2019-03-29 23:09 PDT, EWS Watchlist 		no flags Details
Patch (4.93 KB, patch)
2019-03-30 00:11 PDT, Yusuke Suzuki 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-03-29 21:50:09 PDT 
[JSC] JSRunLoopTimer::Manager should be small
Comment 1 Yusuke Suzuki 2019-03-29 21:50:42 PDT 
Created attachment 366353 [details]
Patch
Comment 2 EWS Watchlist 2019-03-29 23:09:03 PDT 
Comment on attachment 366353 [details]
Patch

Attachment 366353 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11710528

New failing tests:
workers/bomb.html
Comment 3 EWS Watchlist 2019-03-29 23:09:04 PDT 
Created attachment 366359 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 4 Yusuke Suzuki 2019-03-30 00:11:15 PDT 
Created attachment 366361 [details]
Patch
Comment 5 Darin Adler 2019-04-01 08:50:17 PDT 
Comment on attachment 366361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366361&action=review

> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:124
> +            PerVMData& data = *entry.value.get();

Normally if we are using the * operator, we don’t also need to call get(). Unless there is some special consideration here.

> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:202
> +    PerVMData& data = *iter->value.get();

Ditto.

> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:232
> +    PerVMData& data = *iter->value.get();

Ditto.

> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:264
> +    PerVMData& data = *iter->value.get();

Ditto.

> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:282
> +    PerVMData& data = *iter->value.get();

Ditto.
Comment 6 Yusuke Suzuki 2019-04-01 11:21:45 PDT 
Comment on attachment 366361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366361&action=review

>> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:124
>> +            PerVMData& data = *entry.value.get();
> 
> Normally if we are using the * operator, we don’t also need to call get(). Unless there is some special consideration here.

Thanks, you're right. Fixed.

>> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:202
>> +    PerVMData& data = *iter->value.get();
> 
> Ditto.

Fixed.

>> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:232
>> +    PerVMData& data = *iter->value.get();
> 
> Ditto.

Fixed.

>> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:264
>> +    PerVMData& data = *iter->value.get();
> 
> Ditto.

Fixed.

>> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:282
>> +    PerVMData& data = *iter->value.get();
> 
> Ditto.

Fixed.
Comment 7 Yusuke Suzuki 2019-04-01 11:34:05 PDT 
Committed r243702: <https://trac.webkit.org/changeset/243702>
Comment 8 Radar WebKit Bug Importer 2019-04-01 11:35:18 PDT 
<rdar://problem/49487406>