Bug 196419 - Web Inspector: JSC Sampling Profiler thread not getting subtracted in CPU Usage Timeline
Summary: Web Inspector: JSC Sampling Profiler thread not getting subtracted in CPU Usa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-29 19:58 PDT by Joseph Pecoraro
Modified: 2019-03-30 09:38 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.41 KB, patch)
2019-03-29 20:01 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-03-29 19:58:57 PDT 
JSC Sampling Profiler thread not getting subtracted in CPU Usage Timeline

Oops, we forgot to call the platformSaveStateBeforeStarting function in the patch that was put up for review and landed...
Comment 1 Radar WebKit Bug Importer 2019-03-29 19:59:18 PDT 
<rdar://problem/49444023>
Comment 2 Joseph Pecoraro 2019-03-29 20:01:21 PDT 
Created attachment 366346 [details]
[PATCH] Proposed Fix
Comment 3 Devin Rousso 2019-03-29 20:09:06 PDT 
Comment on attachment 366346 [details]
[PATCH] Proposed Fix

r=mews, oops :P
Comment 4 WebKit Commit Bot 2019-03-30 09:38:22 PDT 
Comment on attachment 366346 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 366346

Committed r243679: <https://trac.webkit.org/changeset/243679>
Comment 5 WebKit Commit Bot 2019-03-30 09:38:23 PDT 
All reviewed patches have been landed.  Closing bug.