Bug 196417 - [WPE][GTK][STABLE] webkit_dom_element_html_input_element_set_editing_value should use HTMLInputElement::setValueForUser
Summary: [WPE][GTK][STABLE] webkit_dom_element_html_input_element_set_editing_value sh...
Status: RESOLVED DUPLICATE of bug 196402
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-29 17:43 PDT by Michael Catanzaro
Modified: 2019-04-03 08:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2019-03-29 17:48 PDT, Michael Catanzaro 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-03-29 17:43:36 PDT 
This is a much simpler version of the patches in bug #195708 and bug #196402, intended for the 2.24 branch. We can't just backport those because the second patch adds new web process API.
Comment 1 Michael Catanzaro 2019-03-29 17:48:33 PDT 
Created attachment 366335 [details]
Patch
Comment 2 EWS Watchlist 2019-03-29 17:52:25 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Darin Adler 2019-04-01 08:51:58 PDT 
Comment on attachment 366335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366335&action=review

> Source/WebKit/ChangeLog:3
> +        [WPE][GTK][STABLE] webkit_dom_element_html_input_element_set_editing_value should use HTMLInputElement::setValueForUser

Ideally should explain why. This title just says exactly what the patch does, and not why.
Comment 4 Michael Catanzaro 2019-04-01 10:04:53 PDT 
True. This patch is kinda low-effort since it's not intended for trunk, though. I figure anyone looking at the stable branch can follow the link to Bugzilla.
Comment 5 Carlos Garcia Campos 2019-04-01 22:40:52 PDT 
Comment on attachment 366335 [details]
Patch

I would do this in trunk too, instead of adding new function. This is wrapping an internal function in the end, so it doesn't matter if the name doesn't match.
Comment 6 Michael Catanzaro 2019-04-03 08:01:40 PDT 

*** This bug has been marked as a duplicate of bug 196402 ***