Bug 196417 – [WPE][GTK][STABLE] webkit_dom_element_html_input_element_set_editing_value should use HTMLInputElement::setValueForUser

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKitGTK

[Michael Catanzaro]

This is a much simpler version of the patches in bug #195708 and bug #196402, intended for the 2.24 branch. We can't just backport those because the second patch adds new web process API.

[Michael Catanzaro]

Created attachment 366335 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Darin Adler]

Comment on attachment 366335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366335&action=review

> Source/WebKit/ChangeLog:3
> +        [WPE][GTK][STABLE] webkit_dom_element_html_input_element_set_editing_value should use HTMLInputElement::setValueForUser

Ideally should explain why. This title just says exactly what the patch does, and not why.

[Michael Catanzaro]

True. This patch is kinda low-effort since it's not intended for trunk, though. I figure anyone looking at the stable branch can follow the link to Bugzilla.

[Carlos Garcia Campos]

Comment on attachment 366335 [details]
Patch

I would do this in trunk too, instead of adding new function. This is wrapping an internal function in the end, so it doesn't matter if the name doesn't match.

[Michael Catanzaro]

*** This bug has been marked as a duplicate of bug 196402 ***