Bug 196407 – Move WebResourceLoadStatisticsStore IPC calls from the UI process to the network process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

As part of the move of ITP from the UI process to the network process, the two WebResourceLoadStatisticsStore IPC endpoints were left behind. One of them is the message RequestStorageAccessUnderOpener which underpins the compatibility fix for federated logins using popups. We should redirect these IPC calls to the network process.

[John Wilander]

<rdar://problem/47859936>

[John Wilander]

Created attachment 366311 [details]
Patch

[Brent Fulgham]

Comment on attachment 366311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366311&action=review

r=me

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:-192
> -    void requestStorageAccessUnderOpener(DomainInNeedOfStorageAccess&&, uint64_t openerPageID, OpenerDomain&&);

This looks like a nice bug fix and simplification!

[John Wilander]

Thanks, Brent! I'll wait for some more green bubbles and then land.

[John Wilander]

Comment on attachment 366311 [details]
Patch

The ios-sim bot is in bad shape with thousands of tests failing in various ways. Landing.

[WebKit Commit Bot]

Comment on attachment 366311 [details]
Patch

Clearing flags on attachment: 366311

Committed r243671: <https://trac.webkit.org/changeset/243671>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Comment on attachment 366311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366311&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:663
> +            resourceLoadStatistics->resourceLoadStatisticsUpdated(WTFMove(statistics));

WTFMove() since a for loop, ouch :/
https://bugs.webkit.org/show_bug.cgi?id=200225

[Brent Fulgham]

*** Bug 196318 has been marked as a duplicate of this bug. ***