Bug 196407 - Move WebResourceLoadStatisticsStore IPC calls from the UI process to the network process
Summary: Move WebResourceLoadStatisticsStore IPC calls from the UI process to the netw...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on: 200225
Blocks:
  Show dependency treegraph
 
Reported: 2019-03-29 15:01 PDT by John Wilander
Modified: 2019-07-29 08:29 PDT (History)
4 users (show)

See Also:


Attachments
Patch (48.98 KB, patch)
2019-03-29 15:15 PDT, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2019-03-29 15:01:43 PDT
As part of the move of ITP from the UI process to the network process, the two WebResourceLoadStatisticsStore IPC endpoints were left behind. One of them is the message RequestStorageAccessUnderOpener which underpins the compatibility fix for federated logins using popups. We should redirect these IPC calls to the network process.
Comment 1 John Wilander 2019-03-29 15:02:01 PDT
<rdar://problem/47859936>
Comment 2 John Wilander 2019-03-29 15:15:39 PDT
Created attachment 366311 [details]
Patch
Comment 3 Brent Fulgham 2019-03-29 16:05:28 PDT
Comment on attachment 366311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366311&action=review

r=me

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:-192
> -    void requestStorageAccessUnderOpener(DomainInNeedOfStorageAccess&&, uint64_t openerPageID, OpenerDomain&&);

This looks like a nice bug fix and simplification!
Comment 4 John Wilander 2019-03-29 16:14:42 PDT
Thanks, Brent! I'll wait for some more green bubbles and then land.
Comment 5 John Wilander 2019-03-29 17:42:13 PDT
Comment on attachment 366311 [details]
Patch

The ios-sim bot is in bad shape with thousands of tests failing in various ways. Landing.
Comment 6 WebKit Commit Bot 2019-03-29 18:09:18 PDT
Comment on attachment 366311 [details]
Patch

Clearing flags on attachment: 366311

Committed r243671: <https://trac.webkit.org/changeset/243671>
Comment 7 WebKit Commit Bot 2019-03-29 18:09:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Chris Dumez 2019-07-29 08:28:54 PDT
Comment on attachment 366311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366311&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:663
> +            resourceLoadStatistics->resourceLoadStatisticsUpdated(WTFMove(statistics));

WTFMove() since a for loop, ouch :/
https://bugs.webkit.org/show_bug.cgi?id=200225