As part of the move of ITP from the UI process to the network process, the two WebResourceLoadStatisticsStore IPC endpoints were left behind. One of them is the message RequestStorageAccessUnderOpener which underpins the compatibility fix for federated logins using popups. We should redirect these IPC calls to the network process.
<rdar://problem/47859936>
Created attachment 366311 [details] Patch
Comment on attachment 366311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366311&action=review r=me > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:-192 > - void requestStorageAccessUnderOpener(DomainInNeedOfStorageAccess&&, uint64_t openerPageID, OpenerDomain&&); This looks like a nice bug fix and simplification!
Thanks, Brent! I'll wait for some more green bubbles and then land.
Comment on attachment 366311 [details] Patch The ios-sim bot is in bad shape with thousands of tests failing in various ways. Landing.
Comment on attachment 366311 [details] Patch Clearing flags on attachment: 366311 Committed r243671: <https://trac.webkit.org/changeset/243671>
All reviewed patches have been landed. Closing bug.
Comment on attachment 366311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366311&action=review > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:663 > + resourceLoadStatistics->resourceLoadStatisticsUpdated(WTFMove(statistics)); WTFMove() since a for loop, ouch :/ https://bugs.webkit.org/show_bug.cgi?id=200225
*** Bug 196318 has been marked as a duplicate of this bug. ***