RESOLVED FIXED196404
[Simple line layout] Turn off inline tree generation for multiline content 
https://bugs.webkit.org/show_bug.cgi?id=196404
Summary [Simple line layout] Turn off inline tree generation for multiline content
alan
Reported 2019-03-29 12:05:22 PDT
Line breaking requires some additional context that SLL can't provide atm.
Attachments
Patch (4.91 KB, patch)
2019-03-29 12:30 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.83 KB, patch)
2019-03-29 13:09 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2019-03-29 12:05:50 PDT
<rdar://problem/49234033>
alan
Comment 2 2019-03-29 12:30:24 PDT
Created attachment 366296 [details] Patch
Simon Fraser (smfr)
Comment 3 2019-03-29 13:02:34 PDT
Comment on attachment 366296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366296&action=review > Source/WebCore/ChangeLog:9 > + Currently simple line layout can't provide the correct line breaking context to the inline boxtree when the boxtree is inline tree? > Source/WebCore/ChangeLog:10 > + generated using the simple line runs. This patch limits the generation of such trees to single line. Multiline content will to single lines > LayoutTests/fast/text/simple-line-layout-and-multiline-inlineboxtree.html:7 > + internals.settings.setSimpleLineLayoutDebugBordersEnabled(true); remove
alan
Comment 4 2019-03-29 13:09:29 PDT
Created attachment 366300 [details] Patch
WebKit Commit Bot
Comment 5 2019-03-29 13:26:55 PDT
Comment on attachment 366300 [details] Patch Clearing flags on attachment: 366300 Committed r243660: <https://trac.webkit.org/changeset/243660>
WebKit Commit Bot
Comment 6 2019-03-29 13:26:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-03-29 13:27:24 PDT
<rdar://problem/49432521>
Note You need to log in before you can comment on or make changes to this bug.