Bug 196404 - [Simple line layout] Turn off inline tree generation for multiline content
Summary: [Simple line layout] Turn off inline tree generation for multiline content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-29 12:05 PDT by zalan
Modified: 2019-03-29 13:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.91 KB, patch)
2019-03-29 12:30 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (4.83 KB, patch)
2019-03-29 13:09 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-03-29 12:05:22 PDT
Line breaking requires some additional context that SLL can't provide atm.
Comment 1 zalan 2019-03-29 12:05:50 PDT
<rdar://problem/49234033>
Comment 2 zalan 2019-03-29 12:30:24 PDT
Created attachment 366296 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-03-29 13:02:34 PDT
Comment on attachment 366296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366296&action=review

> Source/WebCore/ChangeLog:9
> +        Currently simple line layout can't provide the correct line breaking context to the inline boxtree when the boxtree is

inline tree?

> Source/WebCore/ChangeLog:10
> +        generated using the simple line runs. This patch limits the generation of such trees to single line. Multiline content will

to single lines

> LayoutTests/fast/text/simple-line-layout-and-multiline-inlineboxtree.html:7
> +    internals.settings.setSimpleLineLayoutDebugBordersEnabled(true);

remove
Comment 4 zalan 2019-03-29 13:09:29 PDT
Created attachment 366300 [details]
Patch
Comment 5 WebKit Commit Bot 2019-03-29 13:26:55 PDT
Comment on attachment 366300 [details]
Patch

Clearing flags on attachment: 366300

Committed r243660: <https://trac.webkit.org/changeset/243660>
Comment 6 WebKit Commit Bot 2019-03-29 13:26:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-03-29 13:27:24 PDT
<rdar://problem/49432521>