WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 196391
[Win][WebKit] MiniBrowser should support high DPI display
https://bugs.webkit.org/show_bug.cgi?id=196391
Summary
[Win][WebKit] MiniBrowser should support high DPI display
Fujii Hironori
Reported
2019-03-28 23:45:11 PDT
[Win][WebKit] MiniBrowser should support high DPI display MiniBrowser shows tiny texts in high DPI display at the moment. In WebKitLegacy Windows port and WebKit other ports, high DPI is supported by WebView, not by applications. I tried this approach in
Bug 196339
. It seems it makes thinks complicated for Windows because Windows window coordinated system differs from other ports. In contrast, it seems easy to implement in the application side just by changing the default page zoom factor.
Attachments
Patch
(2.03 KB, patch)
2019-03-28 23:58 PDT
,
Fujii Hironori
no flags
Details
Formatted Diff
Diff
Patch
(2.39 KB, patch)
2019-03-29 00:10 PDT
,
Fujii Hironori
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Fujii Hironori
Comment 1
2019-03-28 23:58:36 PDT
Created
attachment 366253
[details]
Patch
EWS Watchlist
Comment 2
2019-03-29 00:01:32 PDT
Comment hidden (obsolete)
Attachment 366253
[details]
did not pass style-queue: ERROR: Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:40: Use the class HWndDC instead of calling GetDC to avoid potential memory leaks. [runtime/leaky_pattern] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Fujii Hironori
Comment 3
2019-03-29 00:10:55 PDT
Created
attachment 366255
[details]
Patch
Fujii Hironori
Comment 4
2019-03-31 18:38:36 PDT
Comment on
attachment 366255
[details]
Patch Clearing flags on attachment: 366255 Committed
r243685
: <
https://trac.webkit.org/changeset/243685
>
Fujii Hironori
Comment 5
2019-03-31 18:38:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-03-31 18:39:23 PDT
<
rdar://problem/49464798
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug