Bug 196384 - Worklist should have a more fine grained way to just stop for some VMs
Summary: Worklist should have a more fine grained way to just stop for some VMs
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-28 17:35 PDT by Saam Barati
Modified: 2019-04-07 11:52 PDT (History)
12 users (show)

See Also:

Attachments
WIP (8.66 KB, patch)
2019-03-28 19:02 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (8.66 KB, patch)
2019-04-07 11:52 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-03-28 17:35:29 PDT 
...
Comment 1 Saam Barati 2019-03-28 17:41:21 PDT 
So I have a WIP patch. I'm testing on 2-core x86-64 MBP (using instruments to bring my core count down to 2 w/ hyper threading).

The patch makes us go from total CPU time spent in "Heap::suspendCompilerThreads" from 34000 ms to 400ms. However, it's not a progression on bomb-workers. And there's a slight chance it's even a regression.

I wonder if it's revealing other forms of contention that per-process locking was somehow saving us from.
Comment 2 Saam Barati 2019-03-28 17:49:40 PDT 
When I test in four core mode, it's also repeatably just a bit slower. However, we're also repeatably spending ~2 orders of magnitude less time in Heap::suspendCompilerThreads
Comment 3 Saam Barati 2019-03-28 19:02:23 PDT 
Created attachment 366233 [details]
WIP
Comment 4 Saam Barati 2019-04-07 11:52:21 PDT 
Created attachment 366906 [details]
WIP

Stashing this WIP here.