When the imxvpudecoder is used, the texture sampling of the directviv-uploaded texure returns an RGB value, so there's no need to convert it.
Created attachment 366165 [details] Patch
Comment on attachment 366165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366165&action=review > Source/WebCore/ChangeLog:9 > + directviv-uploaded texure returns an RGB value, so there's no need texture > Source/WebCore/ChangeLog:11 > + ImageRotation flag handling. The flat is now computed once only flag > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:858 > + bool shouldWait = m_videoDecoderPlatform == WebKitGstVideoDecoderPlatform::Video4Linux; > auto proxyOperation = > - [shouldWait = m_isVideoDecoderVideo4Linux, pipeline = pipeline()](TextureMapperPlatformLayerProxy& proxy) > + [shouldWait, pipeline = pipeline()](TextureMapperPlatformLayerProxy& proxy) nit: is there any problem in using this in one line? > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:294 > + mutable WebKitGstVideoDecoderPlatform m_videoDecoderPlatform; Does this need to be mutable?
Comment on attachment 366165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366165&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:294 >> + mutable WebKitGstVideoDecoderPlatform m_videoDecoderPlatform; > > Does this need to be mutable? It indeed does not!
Committed r243644: <https://trac.webkit.org/changeset/243644>
<rdar://problem/49415998>