Bug 196346 – [GStreamer] imxvpudecoder detection and handling

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Philippe Normand]

When the imxvpudecoder is used, the texture sampling of the directviv-uploaded texure returns an RGB value, so there's no need to convert it.

[Philippe Normand]

Created attachment 366165 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 366165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366165&action=review

> Source/WebCore/ChangeLog:9
> +        directviv-uploaded texure returns an RGB value, so there's no need

texture

> Source/WebCore/ChangeLog:11
> +        ImageRotation flag handling. The flat is now computed once only

flag

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:858
> +    bool shouldWait = m_videoDecoderPlatform == WebKitGstVideoDecoderPlatform::Video4Linux;
>      auto proxyOperation =
> -        [shouldWait = m_isVideoDecoderVideo4Linux, pipeline = pipeline()](TextureMapperPlatformLayerProxy& proxy)
> +        [shouldWait, pipeline = pipeline()](TextureMapperPlatformLayerProxy& proxy)

nit: is there any problem in using this in one line?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:294
> +    mutable WebKitGstVideoDecoderPlatform m_videoDecoderPlatform;

Does this need to be mutable?

[Philippe Normand]

Comment on attachment 366165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366165&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:294
>> +    mutable WebKitGstVideoDecoderPlatform m_videoDecoderPlatform;
> 
> Does this need to be mutable?

It indeed does not!

[Philippe Normand]

Committed r243644: <https://trac.webkit.org/changeset/243644>

[Radar WebKit Bug Importer]

<rdar://problem/49415998>