[JSC] Drop VM and Context cache map in JavaScriptCore.framework
Created attachment 366155 [details] Patch
Comment on attachment 366155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366155&action=review > Source/JavaScriptCore/API/JSContext.mm:89 > + toJSGlobalObject(m_context)->setAPIWrapper((__bridge void*)self); Why are these bridge casts?
Comment on attachment 366155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366155&action=review Thanks! >> Source/JavaScriptCore/API/JSContext.mm:89 >> + toJSGlobalObject(m_context)->setAPIWrapper((__bridge void*)self); > > Why are these bridge casts? This makes the code OK even if ARC is enabled, ensuring we do not insert any ARC retaining operations. http://clang.llvm.org/docs/AutomaticReferenceCounting.html#bridged-casts Like this change. https://trac.webkit.org/changeset/233409/webkit
Committed r243617: <https://trac.webkit.org/changeset/243617>
<rdar://problem/49390987>
Committed r247346: <https://trac.webkit.org/changeset/247346>
(In reply to Yusuke Suzuki from comment #6) > Committed r247346: <https://trac.webkit.org/changeset/247346> To clarify, r247346 rolls out r243617. r243617 is invalid.
Radar tracking this rollout fix: <rdar://problem/50484118>
Oops, I was confused. Back to: <rdar://problem/49390987>