Bug 196313 – validateOSREntryValue with Int52 should box the value being checked into double format

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

<rdar://problem/49306703>

[Saam Barati]

Created attachment 366099 [details]
patch

[Yusuke Suzuki]

Comment on attachment 366099 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366099&action=review

r=me

> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:217
>              // Constant AnyInt value is stored as usual boxed value in AbstractValue.

We can change this comment like,

Constant AnyInt value is represented as SpecAnyIntAsDouble value in DFG.

> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:219
>              format = FlushedInt52;
> +            value = jsDoubleNumber(value.asAnyInt());

You can exchange these two lines to align them to the code for FlushedDouble case.

[Saam Barati]

Comment on attachment 366099 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366099&action=review

>> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:217
>>              // Constant AnyInt value is stored as usual boxed value in AbstractValue.
> 
> We can change this comment like,
> 
> Constant AnyInt value is represented as SpecAnyIntAsDouble value in DFG.

This isn't always the case because you have strict and not strict. I'm going to just remove the comment.

>> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:219
>> +            value = jsDoubleNumber(value.asAnyInt());
> 
> You can exchange these two lines to align them to the code for FlushedDouble case.

Sounds good.

[Saam Barati]

Created attachment 366100 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 366100 [details]
patch for landing

Clearing flags on attachment: 366100

Committed r243596: <https://trac.webkit.org/changeset/243596>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.