Bug 196313 - validateOSREntryValue with Int52 should box the value being checked into double format
Summary: validateOSREntryValue with Int52 should box the value being checked into doub...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-27 13:29 PDT by Saam Barati
Modified: 2019-03-27 18:06 PDT (History)
14 users (show)

See Also:

Attachments
patch (3.10 KB, patch)
2019-03-27 13:36 PDT, Saam Barati 		ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing (3.11 KB, patch)
2019-03-27 13:42 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-03-27 13:29:03 PDT 
...
Comment 1 Saam Barati 2019-03-27 13:32:33 PDT 
<rdar://problem/49306703>
Comment 2 Saam Barati 2019-03-27 13:36:23 PDT 
Created attachment 366099 [details]
patch
Comment 3 Yusuke Suzuki 2019-03-27 13:39:30 PDT 
Comment on attachment 366099 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366099&action=review

r=me

> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:217
>              // Constant AnyInt value is stored as usual boxed value in AbstractValue.

We can change this comment like,

Constant AnyInt value is represented as SpecAnyIntAsDouble value in DFG.

> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:219
>              format = FlushedInt52;
> +            value = jsDoubleNumber(value.asAnyInt());

You can exchange these two lines to align them to the code for FlushedDouble case.
Comment 4 Saam Barati 2019-03-27 13:41:28 PDT 
Comment on attachment 366099 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366099&action=review

>> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:217
>>              // Constant AnyInt value is stored as usual boxed value in AbstractValue.
> 
> We can change this comment like,
> 
> Constant AnyInt value is represented as SpecAnyIntAsDouble value in DFG.

This isn't always the case because you have strict and not strict. I'm going to just remove the comment.

>> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:219
>> +            value = jsDoubleNumber(value.asAnyInt());
> 
> You can exchange these two lines to align them to the code for FlushedDouble case.

Sounds good.
Comment 5 Saam Barati 2019-03-27 13:42:44 PDT 
Created attachment 366100 [details]
patch for landing
Comment 6 WebKit Commit Bot 2019-03-27 18:06:07 PDT 
Comment on attachment 366100 [details]
patch for landing

Clearing flags on attachment: 366100

Committed r243596: <https://trac.webkit.org/changeset/243596>
Comment 7 WebKit Commit Bot 2019-03-27 18:06:09 PDT 
All reviewed patches have been landed.  Closing bug.