WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
196308
Add another status-bubble iframe to display results from new EWS
https://bugs.webkit.org/show_bug.cgi?id=196308
Summary
Add another status-bubble iframe to display results from new EWS
Aakash Jain
Reported
2019-03-27 11:59:56 PDT
Add another iframe for status-bubble in Bugzilla to display results from new EWS (
https://ews-build.webkit.org
). Initially, new EWS will only have queues which are not present in existing EWS (e.g.: EWS for API Tests, webkitperl), therefore we should display results from both EWSes.
Attachments
Patch
(5.99 KB, patch)
2019-03-27 12:09 PDT
,
Aakash Jain
lforschler
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2019-03-27 12:09:47 PDT
Created
attachment 366089
[details]
Patch
Jonathan Bedard
Comment 2
2019-03-27 12:55:38 PDT
To be clear, this adds another row of bubbles, right? Also, the intention of this is to eventually remove the current row once we've migrated everything to new EWS, right?
Aakash Jain
Comment 3
2019-03-27 13:46:10 PDT
(In reply to Jonathan Bedard from
comment #2
)
> To be clear, this adds another row of bubbles, right?
It adds more bubbles in same row. Two iframes are aligned horizontally. e.g.:
https://bugs.webkit-uat.org/show_bug.cgi?id=168329
> > Also, the intention of this is to eventually remove the current row once we've migrated everything to new EWS, right?
Yes.
Lucas Forschler
Comment 4
2019-03-27 13:57:13 PDT
Comment on
attachment 366089
[details]
Patch is there any easy way to pull our these URLs into a constant variable and reference that in the code? If we ever change the url, it would make it much easier to update. I think we should consider this for both
https://ews.webkit.org
and webkit-queues.webkit.org.
Aakash Jain
Comment 5
2019-04-04 17:31:28 PDT
> is there any easy way to pull our these URLs into a constant variable and reference that in the code? If we ever change the url, it would make it much easier to update.
Don't see an easy way. Will probably attempt that in a separate patch later. Also going to fix some UI glitches by setting the initial width of iframe to 0px instead of 600px.
Aakash Jain
Comment 6
2019-04-04 17:31:44 PDT
Committed
r243921
: <
https://trac.webkit.org/changeset/243921
>
Radar WebKit Bug Importer
Comment 7
2019-04-04 17:51:22 PDT
<
rdar://problem/49630491
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug