Bug 196290 - [iOS WK2] Fixed elements in frames can be misplaced sometimes
Summary: [iOS WK2] Fixed elements in frames can be misplaced sometimes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 190500
  Show dependency tree / graph
 
Reported: 2019-03-26 22:34 PDT by Simon Fraser (smfr)
Modified: 2019-03-27 10:27 PDT (History)
9 users (show)

See Also:

Attachments
Patch (14.66 KB, patch)
2019-03-26 22:37 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (14.59 KB, patch)
2019-03-26 23:24 PDT, Simon Fraser (smfr) 		fred.wang: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-03-26 22:34:01 PDT 
[iOS WK2] Fixed elements in frames can be misplaced sometimes
Comment 1 Simon Fraser (smfr) 2019-03-26 22:37:34 PDT 
Created attachment 366053 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-03-26 22:40:05 PDT 
<rdar://problem/49313998>
Comment 3 Simon Fraser (smfr) 2019-03-26 23:24:06 PDT 
Created attachment 366055 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2019-03-27 01:56:37 PDT 
Comment on attachment 366055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366055&action=review

> LayoutTests/scrollingcoordinator/ios/fixed-in-frame-layer-reconcile-layer-position.html:54
> +            }, 100);

What is that?
Comment 5 Antti Koivisto 2019-03-27 05:30:55 PDT 
Comment on attachment 366055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366055&action=review

> LayoutTests/scrollingcoordinator/ios/fixed-in-frame-layer-reconcile-layer-position.html:53
> +                //document.getElementById('box').style.top = '20px';
> +                <!-- document.body.style.backgroundColor = 'silver'; -->

Please don't land commented out code.
Comment 6 Simon Fraser (smfr) 2019-03-27 08:33:51 PDT 
https://trac.webkit.org/changeset/243539/webkit
Comment 7 Simon Fraser (smfr) 2019-03-27 08:34:56 PDT 
> https://bugs.webkit.org/attachment.cgi?id=366055&action=review
> 
> > LayoutTests/scrollingcoordinator/ios/fixed-in-frame-layer-reconcile-layer-position.html:53
> > +                //document.getElementById('box').style.top = '20px';
> > +                <!-- document.body.style.backgroundColor = 'silver'; -->
> 
> Please don't land commented out code.

Not even with two kinds of comments? :)

Cleaned up before landing. I didn't need the JS in the iframe.