Bug 196282 - Fix some more deprecation warnings in WKDrawingView
Summary: Fix some more deprecation warnings in WKDrawingView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-26 18:08 PDT by Tim Horton
Modified: 2019-03-27 11:40 PDT (History)
6 users (show)

See Also:

Attachments
Patch (18.90 KB, patch)
2019-03-26 18:15 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-03-26 18:08:04 PDT 
Fix some more deprecation warnings in WKDrawingView
Comment 1 Tim Horton 2019-03-26 18:15:03 PDT 
Created attachment 366032 [details]
Patch
Comment 2 Wenson Hsieh 2019-03-26 18:46:57 PDT 
Comment on attachment 366032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366032&action=review

> Source/WebKit/UIProcess/ios/WKDrawingCoordinator.mm:35
> +#import <WebKitAdditions/WKDrawingCoordinatorAdditions.mm>

Nit - may consider a #if USE(APPLE_INTERNAL_SDK) here, though it's probably not necessary since HAVE(PENCILKIT) is off in all non-internal SDKs, and probably by the time that's no longer the case you would've already moved the code into open source :)
Comment 3 WebKit Commit Bot 2019-03-27 11:23:05 PDT 
Comment on attachment 366032 [details]
Patch

Clearing flags on attachment: 366032

Committed r243553: <https://trac.webkit.org/changeset/243553>
Comment 4 WebKit Commit Bot 2019-03-27 11:23:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-27 11:40:35 PDT 
<rdar://problem/49346030>