WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
196270
[ews-build] Use PostgreSQL for ews.webkit.org database
https://bugs.webkit.org/show_bug.cgi?id=196270
Summary
[ews-build] Use PostgreSQL for ews.webkit.org database
Aakash Jain
Reported
2019-03-26 13:45:39 PDT
Use PostgreSQL for ews.webkit.org database since it's much better than the default sqlite.
Attachments
Patch
(1.73 KB, patch)
2019-03-26 13:46 PDT
,
Aakash Jain
lforschler
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2019-03-26 13:46:22 PDT
Created
attachment 365995
[details]
Patch
Lucas Forschler
Comment 2
2019-03-26 13:52:45 PDT
Comment on
attachment 365995
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=365995&action=review
r+ with assignment fix.
> Tools/BuildSlaveSupport/ews-app/ews-app/settings.py:115 > + }
these are mis-aligned by one char. if we are leaving PORT as empty, do we need to include it at all?
Aakash Jain
Comment 3
2019-03-26 14:03:51 PDT
Comment on
attachment 365995
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=365995&action=review
>> Tools/BuildSlaveSupport/ews-app/ews-app/settings.py:115 >> + } > > these are mis-aligned by one char. > if we are leaving PORT as empty, do we need to include it at all?
Will fix the alignment. PORT defaults to empty:
https://docs.djangoproject.com/en/1.11/ref/settings/#port
So, we can remove the PORT.
Aakash Jain
Comment 4
2019-03-26 14:04:56 PDT
Committed
r243518
: <
https://trac.webkit.org/changeset/243518
>
Radar WebKit Bug Importer
Comment 5
2019-03-26 14:07:29 PDT
<
rdar://problem/49290738
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug