Bug 196267 - Implement async paste method on UIWKInteractionViewProtocol
Summary: Implement async paste method on UIWKInteractionViewProtocol
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-26 13:07 PDT by Wenson Hsieh
Modified: 2019-03-27 07:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.75 KB, patch)
2019-03-26 13:16 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (9.73 KB, patch)
2019-03-26 13:36 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-03-26 13:07:39 PDT 
<rdar://problem/49236346>
Comment 1 Wenson Hsieh 2019-03-26 13:16:30 PDT 
Created attachment 365991 [details]
Patch
Comment 2 Tim Horton 2019-03-26 13:19:51 PDT 
Comment on attachment 365991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365991&action=review

> Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:151
> +    [UIPasteboard generalPasteboard].URLs = @[[NSURL URLWithString:@"https://www.apple.com/"]];

@[ [thing thing] ];?
Comment 3 Wenson Hsieh 2019-03-26 13:22:49 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 365991 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365991&action=review
> 
> > Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:151
> > +    [UIPasteboard generalPasteboard].URLs = @[[NSURL URLWithString:@"https://www.apple.com/"]];
> 
> @[ [thing thing] ];?

The linter seems to complain about spaces around a capture block when I do this (I think it thinks it's a C++ lambda :/)

In any case, I changed this to just be ….URL = [NSURL …];
Comment 4 Wenson Hsieh 2019-03-26 13:36:53 PDT 
Created attachment 365994 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-03-26 14:15:22 PDT 
Comment on attachment 365994 [details]
Patch for landing

Clearing flags on attachment: 365994

Committed r243519: <https://trac.webkit.org/changeset/243519>