RESOLVED FIXED 196267
Implement async paste method on UIWKInteractionViewProtocol
https://bugs.webkit.org/show_bug.cgi?id=196267
Summary Implement async paste method on UIWKInteractionViewProtocol
Wenson Hsieh
Reported 2019-03-26 13:07:39 PDT
Attachments
Patch (9.75 KB, patch)
2019-03-26 13:16 PDT, Wenson Hsieh
thorton: review+
Patch for landing (9.73 KB, patch)
2019-03-26 13:36 PDT, Wenson Hsieh
no flags
Wenson Hsieh
Comment 1 2019-03-26 13:16:30 PDT
Tim Horton
Comment 2 2019-03-26 13:19:51 PDT
Comment on attachment 365991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365991&action=review > Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:151 > + [UIPasteboard generalPasteboard].URLs = @[[NSURL URLWithString:@"https://www.apple.com/"]]; @[ [thing thing] ];?
Wenson Hsieh
Comment 3 2019-03-26 13:22:49 PDT
(In reply to Tim Horton from comment #2) > Comment on attachment 365991 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=365991&action=review > > > Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:151 > > + [UIPasteboard generalPasteboard].URLs = @[[NSURL URLWithString:@"https://www.apple.com/"]]; > > @[ [thing thing] ];? The linter seems to complain about spaces around a capture block when I do this (I think it thinks it's a C++ lambda :/) In any case, I changed this to just be ….URL = [NSURL …];
Wenson Hsieh
Comment 4 2019-03-26 13:36:53 PDT
Created attachment 365994 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-03-26 14:15:22 PDT
Comment on attachment 365994 [details] Patch for landing Clearing flags on attachment: 365994 Committed r243519: <https://trac.webkit.org/changeset/243519>
Note You need to log in before you can comment on or make changes to this bug.