Bug 196255 - [ews-build] Get master_hostname dynamically in master.cfg
Summary: [ews-build] Get master_hostname dynamically in master.cfg
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-26 08:36 PDT by Aakash Jain
Modified: 2019-03-26 11:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2019-03-26 08:37 PDT, Aakash Jain 		lforschler: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-03-26 08:36:41 PDT 
[ews-build] We should get the master_hostname dynamically in master.cfg instead of hard-coding production server hostname.
Comment 1 Aakash Jain 2019-03-26 08:37:56 PDT 
Created attachment 365967 [details]
Patch
Comment 2 Lucas Forschler 2019-03-26 09:34:07 PDT 
Comment on attachment 365967 [details]
Patch

I think we should use pythons optimized code here instead of calling out to shell.
import socket
socket.gethostname()
or
socket.getfqdn()

I don't feel too strongly about it, so I'll r+ this, but in general I would guess it's more efficient.
Comment 3 Aakash Jain 2019-03-26 11:13:40 PDT 
Committed r243508: <https://trac.webkit.org/changeset/243508>
Comment 4 Aakash Jain 2019-03-26 11:14:10 PDT 
> I think we should use pythons optimized code here instead of calling out to shell.
> import socket
> socket.gethostname()
Agree. Used this.
Comment 5 Radar WebKit Bug Importer 2019-03-26 11:14:18 PDT 
<rdar://problem/49281738>