Bug 196232 – FontFace constructor throws an exception when there is a name which starts with a number

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ryosuke Niwa]

new FontFace('x 2y', 'url(abc.woff2)') throws an exception in Safari 12.2 but not in Chrome or Firefox.

[Ryosuke Niwa]

Huh, Blink doesn't seem to do any validation for the font name at all :(
https://github.com/chromium/chromium/blob/master/third_party/blink/renderer/core/css/font_face.cc#L200

[Myles C. Maxfield]

Oh, it's because there's a space in there.

[Myles C. Maxfield]

This is because of the historical difference between font-family:foo; and font-family:”foo”;

FontFace::parseString() is passing its argument directly to consumeFontFamilyDescriptor() in CSSPropertyParser.cpp, which parses the string according to the first form. The first form doesn’t allow spaces.

We should adopt the Chrome/Firefox behavior, and the spec should be clarified here.

[Ryosuke Niwa]

Created attachment 366004 [details]
Reduction

In Chrome & Firefox, this file would say "OK". In WebKit, it does not.

[Radar WebKit Bug Importer]

<rdar://problem/49293978>

[Ryosuke Niwa]

Relevant spec text:
https://drafts.csswg.org/css-font-loading/#font-face-constructor

> 1. ...
> Parse the family argument, and the members of the descriptors argument, according to > the grammars of the corresponding descriptors of the CSS @font-face rule
> ...

https://drafts.csswg.org/css-fonts-4/#font-face-rule
https://drafts.csswg.org/css-fonts-4/#font-family-desc
https://drafts.csswg.org/css-fonts-4/#family-name-value

Then finally,
https://drafts.csswg.org/css-fonts-4/#family-name-syntax
> Font family names other than generic families must either be given quoted as <string>s, or unquoted as a sequence of one or more identifiers.
> ...
> If a sequence of identifiers is given as a <family-name>, the computed value is the name converted to a string by joining all the identifiers in the sequence by single spaces.

[Ryosuke Niwa]

We probably need to amend the following text for FontFace constructor:

https://drafts.csswg.org/css-font-loading/#font-face-constructor

> If any of them fail to parse correctly, reject font face’s [[FontStatusPromise]] with a DOMException named "SyntaxError", set font face’s corresponding attributes to the empty string, and set font face’s status attribute to "error". Otherwise, set font face’s corresponding attributes to the serialization of the parsed values.

[Myles C. Maxfield]

https://github.com/w3c/csswg-drafts/issues/3776

[Myles C. Maxfield]

Created attachment 366226 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 366226 [details]
Patch

Clearing flags on attachment: 366226

Committed r243637: <https://trac.webkit.org/changeset/243637>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.