Bug 196231 - Web Inspector: DOMDebugger: move breakpoint storage to use `WI.ObjectStore`
Summary: Web Inspector: DOMDebugger: move breakpoint storage to use `WI.ObjectStore`
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-25 16:58 PDT by Devin Rousso
Modified: 2019-04-15 12:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.59 KB, patch)
2019-03-25 17:22 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-03-25 16:58:00 PDT 
Rather than having to `JSON.stringify` and `JSON.parse` each breakpoint in a giant list on `localStorage`, we can leverage IndexedDB to store breakpoints in a more "friendly" way.  Additionally, this would allow us to not have to re-serialize all breakpoints when saving an update to a single breakpoint.
Comment 1 Radar WebKit Bug Importer 2019-03-25 17:03:32 PDT 
<rdar://problem/49236864>
Comment 2 Devin Rousso 2019-03-25 17:22:29 PDT 
Created attachment 365924 [details]
Patch
Comment 3 Joseph Pecoraro 2019-04-15 11:35:44 PDT 
Comment on attachment 365924 [details]
Patch

r=me, nice!
Comment 4 WebKit Commit Bot 2019-04-15 12:17:19 PDT 
Comment on attachment 365924 [details]
Patch

Clearing flags on attachment: 365924

Committed r244279: <https://trac.webkit.org/changeset/244279>
Comment 5 WebKit Commit Bot 2019-04-15 12:17:20 PDT 
All reviewed patches have been landed.  Closing bug.