Bug 196215 - Web Inspector: Green highlight disappears from edited properties when adding a new property
Summary: Web Inspector: Green highlight disappears from edited properties when adding ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-25 14:13 PDT by Nikita Vasilyev
Modified: 2019-04-14 19:02 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-03-25 14:13:49 PDT 
# STEPS TO REPRODUCE:
1. inspect any page (https://devinrousso.com/demo/WebKit/test.html)
2. open the Elements tab
3. select any element that has at least one rule with at least two properties
4. disable (e.g. comment out) the first property of the rule with at least two properties
5. add a new property immediately after the first property
 => the green "modified" border/highlight next to the first property disappears

NOTES:
The problem is that properties get recreated (when they shouldn't be) and the recreated properties no longer have initialState.

Technically, this broke with https://trac.webkit.org/changeset/243256/webkit. However, reverting it is unlikely to be the correct solution.
Comment 1 Radar WebKit Bug Importer 2019-03-25 14:25:01 PDT 
<rdar://problem/49229170>
Comment 2 Nikita Vasilyev 2019-04-14 19:02:39 PDT 
This should be addressed by the patch in https://bugs.webkit.org/show_bug.cgi?id=195264#c17.