Bug 196193 - Pull IPadUserInterfaceSwizzler out into a separate header file
Summary: Pull IPadUserInterfaceSwizzler out into a separate header file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2019-03-24 22:39 PDT by Wenson Hsieh
Modified: 2019-03-25 12:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.60 KB, patch)
2019-03-24 22:40 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (6.63 KB, patch)
2019-03-25 08:16 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-03-24 22:39:36 PDT 
Pull IPadUserInterfaceSwizzler out into a separate header file
Comment 1 Wenson Hsieh 2019-03-24 22:40:56 PDT 
Created attachment 365850 [details]
Patch
Comment 2 Anders Carlsson 2019-03-25 08:08:09 PDT 
Comment on attachment 365850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365850&action=review

> Tools/TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h:41
> +    static UIUserInterfaceIdiom padUserInterfaceIdiom()

Shouldn't this at least take self and _cmd parameters?
Comment 3 Wenson Hsieh 2019-03-25 08:16:57 PDT 
Created attachment 365864 [details]
Patch
Comment 4 Wenson Hsieh 2019-03-25 08:17:08 PDT 
(In reply to Anders Carlsson from comment #2)
> Comment on attachment 365850 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365850&action=review
> 
> > Tools/TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h:41
> > +    static UIUserInterfaceIdiom padUserInterfaceIdiom()
> 
> Shouldn't this at least take self and _cmd parameters?

It probably should!
Comment 5 Wenson Hsieh 2019-03-25 11:43:08 PDT 
Comment on attachment 365864 [details]
Patch

Thanks for the review!
Comment 6 WebKit Commit Bot 2019-03-25 12:09:23 PDT 
Comment on attachment 365864 [details]
Patch

Clearing flags on attachment: 365864

Committed r243445: <https://trac.webkit.org/changeset/243445>
Comment 7 WebKit Commit Bot 2019-03-25 12:09:25 PDT 
All reviewed patches have been landed.  Closing bug.