Bug 196180 – [Apple Pay] Remove the AvailablePaymentNetworks synchronous message

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Apple Pay] Remove the AvailablePaymentNetworks synchronous message

[Andy Estes]

Created attachment 365819 [details]
Patch

[Andy Estes]

Created attachment 365837 [details]
Patch

[youenn fablet]

Comment on attachment 365837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365837&action=review

> Source/WebKit/WebProcess/ApplePay/cocoa/WebPaymentCoordinatorCocoa.mm:46
> +        result.uncheckedAppend(network);

Can we add them to m_availablePaymentNetworks directly and return void?
Or better, return a AvailablePaymentNetworksSet directly and make this a free function or a static WebPaymentCoordinator one.
We could also change WebPaymentCoordinator::availablePaymentNetworks():
if (!m_availablePaymentNetworks)
    m_availablePaymentNetworks = platformAvailablePaymentNetworks();
return *m_availablePaymentNetworks;

> Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:133
> +    if (WebCore::AXObjectCache* cache = [self axObjectCache]) {

auto?

[Andy Estes]

Created attachment 365874 [details]
Patch

[Andy Estes]

(In reply to youenn fablet from comment #3)
> Comment on attachment 365837 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365837&action=review
> 
> > Source/WebKit/WebProcess/ApplePay/cocoa/WebPaymentCoordinatorCocoa.mm:46
> > +        result.uncheckedAppend(network);
> 
> Can we add them to m_availablePaymentNetworks directly and return void?
> Or better, return a AvailablePaymentNetworksSet directly and make this a
> free function or a static WebPaymentCoordinator one.
> We could also change WebPaymentCoordinator::availablePaymentNetworks():
> if (!m_availablePaymentNetworks)
>     m_availablePaymentNetworks = platformAvailablePaymentNetworks();
> return *m_availablePaymentNetworks;

I got rid of availablePaymentNetworks entirely and moved its logic into validatedPaymentNetwork. I made platformAvailablePaymentNetworks return a AvailablePaymentNetworksSet as you suggested.

> 
> > Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:133
> > +    if (WebCore::AXObjectCache* cache = [self axObjectCache]) {
> 
> auto?

Yep. Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 365874 [details]
Patch

Clearing flags on attachment: 365874

Committed r243443: <https://trac.webkit.org/changeset/243443>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49222105>