WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
196180
[Apple Pay] Remove the AvailablePaymentNetworks synchronous message
https://bugs.webkit.org/show_bug.cgi?id=196180
Summary
[Apple Pay] Remove the AvailablePaymentNetworks synchronous message
Andy Estes
Reported
2019-03-23 15:39:32 PDT
[Apple Pay] Remove the AvailablePaymentNetworks synchronous message
Attachments
Patch
(14.10 KB, patch)
2019-03-23 15:42 PDT
,
Andy Estes
no flags
Details
Formatted Diff
Diff
Patch
(14.07 KB, patch)
2019-03-24 13:19 PDT
,
Andy Estes
no flags
Details
Formatted Diff
Diff
Patch
(14.59 KB, patch)
2019-03-25 10:35 PDT
,
Andy Estes
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Andy Estes
Comment 1
2019-03-23 15:42:04 PDT
Comment hidden (obsolete)
Created
attachment 365819
[details]
Patch
Andy Estes
Comment 2
2019-03-24 13:19:39 PDT
Created
attachment 365837
[details]
Patch
youenn fablet
Comment 3
2019-03-25 08:41:43 PDT
Comment on
attachment 365837
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=365837&action=review
> Source/WebKit/WebProcess/ApplePay/cocoa/WebPaymentCoordinatorCocoa.mm:46 > + result.uncheckedAppend(network);
Can we add them to m_availablePaymentNetworks directly and return void? Or better, return a AvailablePaymentNetworksSet directly and make this a free function or a static WebPaymentCoordinator one. We could also change WebPaymentCoordinator::availablePaymentNetworks(): if (!m_availablePaymentNetworks) m_availablePaymentNetworks = platformAvailablePaymentNetworks(); return *m_availablePaymentNetworks;
> Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:133 > + if (WebCore::AXObjectCache* cache = [self axObjectCache]) {
auto?
Andy Estes
Comment 4
2019-03-25 10:35:07 PDT
Created
attachment 365874
[details]
Patch
Andy Estes
Comment 5
2019-03-25 10:48:21 PDT
(In reply to youenn fablet from
comment #3
)
> Comment on
attachment 365837
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=365837&action=review
> > > Source/WebKit/WebProcess/ApplePay/cocoa/WebPaymentCoordinatorCocoa.mm:46 > > + result.uncheckedAppend(network); > > Can we add them to m_availablePaymentNetworks directly and return void? > Or better, return a AvailablePaymentNetworksSet directly and make this a > free function or a static WebPaymentCoordinator one. > We could also change WebPaymentCoordinator::availablePaymentNetworks(): > if (!m_availablePaymentNetworks) > m_availablePaymentNetworks = platformAvailablePaymentNetworks(); > return *m_availablePaymentNetworks;
I got rid of availablePaymentNetworks entirely and moved its logic into validatedPaymentNetwork. I made platformAvailablePaymentNetworks return a AvailablePaymentNetworksSet as you suggested.
> > > Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:133 > > + if (WebCore::AXObjectCache* cache = [self axObjectCache]) { > > auto?
Yep. Thanks for reviewing!
WebKit Commit Bot
Comment 6
2019-03-25 11:26:15 PDT
Comment on
attachment 365874
[details]
Patch Clearing flags on attachment: 365874 Committed
r243443
: <
https://trac.webkit.org/changeset/243443
>
WebKit Commit Bot
Comment 7
2019-03-25 11:26:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8
2019-03-25 11:27:24 PDT
<
rdar://problem/49222105
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug