Bug 196164 – Animated keyboard scrolling is extremely chaotic

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Animated keyboard scrolling is extremely chaotic

[Tim Horton]

Created attachment 365773 [details]
Patch

[Tim Horton]

<rdar://problem/48702444>

[Tim Horton]

Comment on attachment 365773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365773&action=review

> Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:360
> +    WTFLogAlways("THORTON STOP");

Obviously without this 🙃

[Simon Fraser (smfr)]

Comment on attachment 365773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365773&action=review

> Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.h:65
> +- (BOOL)hasScrollingKeyPressed;

I don't like this term. It's no clear if it means "scrolling key is currently depressed", or "scrolling key was pressed sometime in the past".

[Tim Horton]

(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 365773 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365773&action=review
> 
> > Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.h:65
> > +- (BOOL)hasScrollingKeyPressed;
> 
> I don't like this term. It's no clear if it means "scrolling key is
> currently depressed", or "scrolling key was pressed sometime in the past".

As you might be able to tell from the renaming in this patch, I'm having the same fight with myself :D

I'll try a third name.

[Tim Horton]

Created attachment 365889 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 365889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365889&action=review

> Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.h:65
> +- (BOOL)hasScrollingKeyDown;

scrollTriggeringKeyIsPressed / scrollTriggeringKeyIsDown?

[Tim Horton]

Created attachment 365890 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365890 [details]
Patch

Clearing flags on attachment: 365890

Committed r243454: <https://trac.webkit.org/changeset/243454>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.