Bug 196161 – Re-enable safe browsing in WKWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Re-enable safe browsing in WKWebView

[Alex Christensen]

Created attachment 365765 [details]
Patch

[Alex Christensen]

<rdar://problem/49171413>

[EWS Watchlist]

Comment on attachment 365765 [details]
Patch

Attachment 365765 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11617844

New failing tests:
http/tests/navigation/keyboard-events-during-provisional-navigation.html
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html

[EWS Watchlist]

Created attachment 365777 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Geoffrey Garen]

Comment on attachment 365765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365765&action=review

> LayoutTests/ChangeLog:9
> +        * platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:

Regressions: Unexpected text-only failures (1)
  http/tests/navigation/keyboard-events-during-provisional-navigation.html [ Failure ]

[Alex Christensen]

Created attachment 365983 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365983 [details]
Patch

Clearing flags on attachment: 365983

Committed r246127: <https://trac.webkit.org/changeset/246127>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

Comment on attachment 365983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365983&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h:59
> +/*! @abstract A Boolean value indicating whether warnings should be
> + shown for suspected fraudulent content such as phishing or malware.
> + @discussion The default value is YES. This feature is currently available
> + in the following region: China.
> + */
> +@property (nonatomic, getter=isFraudulentWebsiteWarningEnabled) BOOL fraudulentWebsiteWarningEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

It's only available in China?

[Maciej Stachowiak]

Unfortunately, we don't currently have the ability to offer this feature in other regions.