Include the CFNetworking task UUID to the NSError when a resource-load fails

[Keith Rollin]

In order to help track the connection between a failed resource-load and a user-visible error message, include the CFNetworking task UUID in the associated error as an element of the userInfo property. This can then be pulled out and reported in the logging at the point the error is reported to the user.

<rdar://problem/49128864>

[Keith Rollin]

Created attachment 365753 [details]
Patch

[Alex Christensen]

Comment on attachment 365753 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365753&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:611
> +        newUserInfo[@"networkTaskID"] = [task description];

Maybe we should have "Description" in the key instead of "ID"

[EWS Watchlist]

Comment on attachment 365753 [details]
Patch

Attachment 365753 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11616331

New failing tests:
fast/visual-viewport/ios/min-scale-greater-than-one.html

[EWS Watchlist]

Created attachment 365758 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Keith Rollin]

Created attachment 366106 [details]
Patch

[Keith Rollin]

Changed ID to Description.

Those test failures aren't mine.

[WebKit Commit Bot]

Comment on attachment 366106 [details]
Patch

Clearing flags on attachment: 366106

Committed r243565: <https://trac.webkit.org/changeset/243565>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.