RESOLVED FIXED 196143
[GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs 
https://bugs.webkit.org/show_bug.cgi?id=196143
Summary [GTK][WPE] check-webkit-style doesn't complain about identifiers with undersc...
Carlos Garcia Campos
Reported 2019-03-22 04:38:13 PDT
There's an exception for identifiers that start with webki_ under those directories, but the check for that exception is not correct.
Attachments
Patch (3.09 KB, patch)
2019-03-22 04:41 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.78 MB, application/zip)
2019-03-22 06:25 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-03-22 04:41:24 PDT
Created attachment 365710 [details] Patch
EWS Watchlist
Comment 2 2019-03-22 06:25:04 PDT
Comment on attachment 365710 [details] Patch Attachment 365710 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11612580 New failing tests: http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html
EWS Watchlist
Comment 3 2019-03-22 06:25:06 PDT
Created attachment 365719 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 4 2019-03-23 04:26:04 PDT
Comment on attachment 365710 [details] Patch Clearing flags on attachment: 365710 Committed r243411: <https://trac.webkit.org/changeset/243411>
WebKit Commit Bot
Comment 5 2019-03-23 04:26:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-03-23 17:49:42 PDT
<rdar://problem/49191253>
Note You need to log in before you can comment on or make changes to this bug.