196126 – REGRESSION (r242687): Flicker when pinch-zooming pages in macOS Safari

Bug 196126 - REGRESSION (r242687): Flicker when pinch-zooming pages in macOS Safari

Summary: REGRESSION (r242687): Flicker when pinch-zooming pages in macOS Safari

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Simon Fraser (smfr)

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2019-03-21 19:07 PDT by Simon Fraser (smfr)
Modified:	2019-03-25 16:11 PDT (History)
CC List:	10 users (show)

See Also:

Attachments
Patch (5.10 KB, patch) 2019-03-21 19:08 PDT, Simon Fraser (smfr)	no flags	Details \| Formatted Diff \| Diff
Patch (5.13 KB, patch) 2019-03-21 19:12 PDT, Simon Fraser (smfr)	koivisto: review+	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Fraser (smfr) 2019-03-21 19:07:32 PDT

REGRESSION (r242687): Flicker when pinch-zooming pages in macOS Safari

Comment 1 Simon Fraser (smfr) 2019-03-21 19:08:29 PDT Comment hidden (obsolete)

Created attachment 365665 [details]
Patch

Comment 2 Simon Fraser (smfr) 2019-03-21 19:08:31 PDT

<rdar://problem/49095791>

Comment 3 EWS Watchlist 2019-03-21 19:10:25 PDT Comment hidden (obsolete)

Attachment 365665 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Simon Fraser (smfr) 2019-03-21 19:12:46 PDT

Created attachment 365667 [details]
Patch

Comment 5 Antti Koivisto 2019-03-22 09:11:49 PDT

Comment on attachment 365667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365667&action=review

> Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:91
> +    enum class FlushingForTransientZoom { Yes, No };

Something like

enum class FlushType { Normal, TransientZoom };

is another option here.

Comment 6 Simon Fraser (smfr) 2019-03-22 09:39:30 PDT

https://trac.webkit.org/changeset/243381/webkit

Comment 7 Simon Fraser (smfr) 2019-03-25 16:11:37 PDT

Followup fix in https://trac.webkit.org/r243469