Bug 196126 – REGRESSION (r242687): Flicker when pinch-zooming pages in macOS Safari

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

REGRESSION (r242687): Flicker when pinch-zooming pages in macOS Safari

[Simon Fraser (smfr)]

Created attachment 365665 [details]
Patch

[Simon Fraser (smfr)]

<rdar://problem/49095791>

[EWS Watchlist]

Attachment 365665 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 365667 [details]
Patch

[Antti Koivisto]

Comment on attachment 365667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365667&action=review

> Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:91
> +    enum class FlushingForTransientZoom { Yes, No };

Something like

enum class FlushType { Normal, TransientZoom };

is another option here.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/243381/webkit

[Simon Fraser (smfr)]

Followup fix in https://trac.webkit.org/r243469