Bug 196122 - [JSC] Shrink sizeof(FunctionExecutable) by 16bytes
Summary: [JSC] Shrink sizeof(FunctionExecutable) by 16bytes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-21 17:54 PDT by Yusuke Suzuki
Modified: 2019-03-22 00:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (36.73 KB, patch)
2019-03-21 17:59 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Patch for landing (37.42 KB, patch)
2019-03-21 19:26 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-03-21 17:54:43 PDT 
[JSC] Shrink sizeof(FunctionExecutable) by 16bytes
Comment 1 Yusuke Suzuki 2019-03-21 17:59:39 PDT 
Created attachment 365659 [details]
Patch
Comment 2 Saam Barati 2019-03-21 19:03:21 PDT 
Comment on attachment 365659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365659&action=review

> Source/JavaScriptCore/runtime/GlobalExecutable.h:34
> +    friend class LLIntOffsetsExtractor;

why?
Comment 3 Yusuke Suzuki 2019-03-21 19:26:36 PDT 
Comment on attachment 365659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365659&action=review

>> Source/JavaScriptCore/runtime/GlobalExecutable.h:34
>> +    friend class LLIntOffsetsExtractor;
> 
> why?

It should be removed. Thanks
Comment 4 Yusuke Suzuki 2019-03-21 19:26:59 PDT 
Created attachment 365670 [details]
Patch for landing
Comment 5 Yusuke Suzuki 2019-03-22 00:14:50 PDT 
Committed r243365: <https://trac.webkit.org/changeset/243365>
Comment 6 Radar WebKit Bug Importer 2019-03-22 00:16:48 PDT 
<rdar://problem/49143440>
Comment 7 Yusuke Suzuki 2019-03-22 00:39:50 PDT 
Committed r243367: <https://trac.webkit.org/changeset/243367>