Bug 196113 - Remove last use of LegacySync IPC messages
Summary: Remove last use of LegacySync IPC messages
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2019-03-21 14:49 PDT by Alex Christensen
Modified: 2019-03-25 16:12 PDT (History)
4 users (show)

See Also:

Patch (90.04 KB, patch)
2019-03-21 15:06 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (91.46 KB, patch)
2019-03-21 15:13 PDT, Alex Christensen
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-03-21 14:49:00 PDT
Remove last use of LegacySync IPC messages
Comment 1 Chris Dumez 2019-03-21 14:53:43 PDT
Comment 2 Alex Christensen 2019-03-21 15:06:38 PDT
Created attachment 365622 [details]
Comment 3 Alex Christensen 2019-03-21 15:13:14 PDT
Created attachment 365627 [details]
Comment 4 Chris Dumez 2019-03-21 15:15:18 PDT
Comment on attachment 365627 [details]

r=me if the bots are happy.
Comment 5 Alexey Proskuryakov 2019-03-21 20:10:44 PDT
Looks like at least a retry is needed, as the patch failed to apply on several important bots.
Comment 6 Alex Christensen 2019-03-22 09:11:19 PDT
The patch failed to apply on some bots because I had already committed this to https://trac.webkit.org/changeset/243345/webkit once I saw that it built on all platforms and passed tests
Comment 7 Radar WebKit Bug Importer 2019-03-22 09:12:19 PDT
Comment 8 Truitt Savell 2019-03-22 10:40:30 PDT
It looks like the changes in https://trac.webkit.org/changeset/243345/webkit

has caused legacy-animation-engine/animations/resume-after-page-cache.html

to become a flakey timeout and more consistent failure.


I was able to reproduce with command:

run-webkit-tests legacy-animation-engine/animations/resume-after-page-cache.html --iterations 100 -f --force

the test does not timeout on 243345 and does on 243346
Comment 9 Truitt Savell 2019-03-22 10:49:54 PDT
animations/resume-after-page-cache.html is also timing out.

Comment 10 Shawn Roberts 2019-03-25 16:01:49 PDT
It looks like the changes in https://trac.webkit.org/changeset/243345/webkit

is causing the following tests to fail around 75% of the time on Mac and iOS Simulator WK2 and Debug

http/tests/cache-storage/cache-records-persistency.https.html (was marked flaky previously on Mac)

Dashboard :


Prior to change the tests were still flaky failures, but after this change they have about a 75% failure rate.

Reproduced with :

run-webkit-tests http/tests/cache-storage/cache-records-persistency.https.html http/tests/cache-storage/cache-clearing-origin.https.html --iterations 100 --child-process 1 --ios-simulator --exit-after-n-failures=10 --no-retry
Comment 11 Shawn Roberts 2019-03-25 16:12:14 PDT
Ignore the above comment. It looks like I'm blaming the wrong revision.