Bug 196113 – Remove last use of LegacySync IPC messages

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Remove last use of LegacySync IPC messages

[Chris Dumez]

\o/

[Alex Christensen]

Created attachment 365622 [details]
Patch

[Alex Christensen]

Created attachment 365627 [details]
Patch

[Chris Dumez]

Comment on attachment 365627 [details]
Patch

r=me if the bots are happy.

[Alexey Proskuryakov]

Looks like at least a retry is needed, as the patch failed to apply on several important bots.

[Alex Christensen]

The patch failed to apply on some bots because I had already committed this to https://trac.webkit.org/changeset/243345/webkit once I saw that it built on all platforms and passed tests

[Radar WebKit Bug Importer]

<rdar://problem/49155685>

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/243345/webkit

has caused legacy-animation-engine/animations/resume-after-page-cache.html

to become a flakey timeout and more consistent failure.

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=legacy-animation-engine%2Fanimations%2Fresume-after-page-cache.html

I was able to reproduce with command:

run-webkit-tests legacy-animation-engine/animations/resume-after-page-cache.html --iterations 100 -f --force

the test does not timeout on 243345 and does on 243346

[Truitt Savell]

animations/resume-after-page-cache.html is also timing out.

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=animations%2Fresume-after-page-cache.html

[Shawn Roberts]

It looks like the changes in https://trac.webkit.org/changeset/243345/webkit

is causing the following tests to fail around 75% of the time on Mac and iOS Simulator WK2 and Debug

http/tests/cache-storage/cache-records-persistency.https.html (was marked flaky previously on Mac)
http/tests/cache-storage/cache-clearing-origin.https.html

Dashboard :

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html?tests=http%2Ftests%2Fcache-storage%2Fcache-records-persistency.https.html+performance-api%2Fperformance-observer-periodic.html+scrollingcoordinator%2Fios%2Fui-scroll-fixed.html+storage%2Findexeddb%2Fmodern%2Fidbtransaction-objectstore-failures-private.html#showAllRuns=true&tests=http%2Ftests%2Fcache-storage%2Fcache-records-persistency.https.html%20http%2Ftests%2Fcache-storage%2Fcache-clearing-origin.https.html

Prior to change the tests were still flaky failures, but after this change they have about a 75% failure rate.

Reproduced with :

run-webkit-tests http/tests/cache-storage/cache-records-persistency.https.html http/tests/cache-storage/cache-clearing-origin.https.html --iterations 100 --child-process 1 --ios-simulator --exit-after-n-failures=10 --no-retry

[Shawn Roberts]

Ignore the above comment. It looks like I'm blaming the wrong revision.