Labels that only contains static text should not have children because the label is a static text.
<rdar://problem/49124032>
Created attachment 365769 [details] Patch
Comment on attachment 365769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365769&action=review > Source/WebCore/accessibility/AccessibilityLabel.cpp:119 > + m_children.clear(); This seems like it should be covered by the dirty Boolean flag of the same name The way it’s coded now it will clear the children every time it’s asked (it appears)
Comment on attachment 365769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365769&action=review >> Source/WebCore/accessibility/AccessibilityLabel.cpp:119 >> + m_children.clear(); > > This seems like it should be covered by the dirty Boolean flag of the same name > > The way it’s coded now it will clear the children every time it’s asked (it appears) any comment on this?
Yes apparently I found issue on this patch. Somehow the children are still there. This needs rework apparently.