Bug 196111 - AX: labels that only contains static text should not have children
Summary: AX: labels that only contains static text should not have children
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-21 14:22 PDT by Eric Liang
Modified: 2021-08-31 09:36 PDT (History)
10 users (show)

See Also:


Attachments
Patch (6.17 KB, patch)
2019-03-22 16:00 PDT, Eric Liang
cfleizach: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Liang 2019-03-21 14:22:48 PDT
Labels that only contains static text should not have children because the label is a static text.
Comment 1 Radar WebKit Bug Importer 2019-03-21 14:24:14 PDT
<rdar://problem/49124032>
Comment 2 Eric Liang 2019-03-22 16:00:03 PDT
Created attachment 365769 [details]
Patch
Comment 3 chris fleizach 2019-03-24 10:04:04 PDT
Comment on attachment 365769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365769&action=review

> Source/WebCore/accessibility/AccessibilityLabel.cpp:119
> +        m_children.clear();

This seems like it should be covered by the dirty Boolean flag of the same name

The way it’s coded now it will clear the children every time it’s asked (it appears)
Comment 4 chris fleizach 2019-04-08 10:32:54 PDT
Comment on attachment 365769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365769&action=review

>> Source/WebCore/accessibility/AccessibilityLabel.cpp:119
>> +        m_children.clear();
> 
> This seems like it should be covered by the dirty Boolean flag of the same name
> 
> The way it’s coded now it will clear the children every time it’s asked (it appears)

any comment on this?
Comment 5 Eric Liang 2019-04-08 10:38:59 PDT
Yes apparently I found issue on this patch. Somehow the children are still there. This needs rework apparently.