Bug 196107 – WIP: [Web GPU] Prototype compute pipeline with MSL

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Justin Fan]

[Web GPU] Prototype compute pipeline with MSL

[Justin Fan]

<rdar://problem/46289650>

[Justin Fan]

Created attachment 365629 [details]
Patch

[Justin Fan]

Created attachment 365633 [details]
Patch

[Justin Fan]

Created attachment 365635 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 365635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365635&action=review

> Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:69
> +    virtual void setVertexBuffer(const MTLBuffer *, unsigned, unsigned) { }
> +    virtual void setFragmentBuffer(const MTLBuffer *, unsigned, unsigned) { }
> +    // Compute.
> +    virtual void setComputeBuffer(const MTLBuffer *, unsigned, unsigned) { }

https://github.com/gpuweb/gpuweb/commit/678d728f20730b03134509c75aaa4f197a3cb8df

[Justin Fan]

(In reply to Myles C. Maxfield from comment #5)
> Comment on attachment 365635 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365635&action=review
> 
> > Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:69
> > +    virtual void setVertexBuffer(const MTLBuffer *, unsigned, unsigned) { }
> > +    virtual void setFragmentBuffer(const MTLBuffer *, unsigned, unsigned) { }
> > +    // Compute.
> > +    virtual void setComputeBuffer(const MTLBuffer *, unsigned, unsigned) { }
> 
> https://github.com/gpuweb/gpuweb/commit/
> 678d728f20730b03134509c75aaa4f197a3cb8df

I'm using a fat interface here so that setBindGroup can delegate behavior. If it's an error to set a bind group with a compute resource on a render pipeline or vv, we can add validation here.

[EWS Watchlist]

Comment on attachment 365635 [details]
Patch

Attachment 365635 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11607391

New failing tests:
webgpu/compute-squares.html
http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html

[EWS Watchlist]

Created attachment 365662 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Justin Fan]

Created attachment 365757 [details]
Patch

[Justin Fan]

Created attachment 365760 [details]
Patch

[EWS Watchlist]

Comment on attachment 365760 [details]
Patch

Attachment 365760 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11617360

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
webgpu/compute-squares.html

[EWS Watchlist]

Created attachment 365767 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Justin Fan]

Created attachment 365768 [details]
Patch

[EWS Watchlist]

Comment on attachment 365768 [details]
Patch

Attachment 365768 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11618518

New failing tests:
webgpu/compute-squares.html

[EWS Watchlist]

Created attachment 365785 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Justin Fan]

Created attachment 365821 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365821 [details]
Patch

Clearing flags on attachment: 365821

Committed r243419: <https://trac.webkit.org/changeset/243419>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

It looks like the test webgpu/compute-squares.html 

is causing the Mac WK2 bots to crash and become unresponsive, requiring a reboot. 

using this run as an example: https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/3301

when you look at the layout-test logs: https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/3301/steps/layout-test/logs/stdio

webgpu/command-buffers.html is the last webgpu/ test to run successfully which is followed by the new webgpu/compute-squares.html test. After that point the bots become unresponsive and require reboot. All WK2 layout-tests logs show webgpu/command-buffers.html as the last test to run before the bot fails. 

I am going to roll out this change to confirm and get the bots functioning again.

[Truitt Savell]

Reverted r243419 for reason:

Caused Mac WK2 testers to crash and become unresponsive.

Committed r243457: <https://trac.webkit.org/changeset/243457>

[Truitt Savell]

Created attachment 365916 [details]
Crash log

Attaching a crash log I found on bot198 from today. only found one though the bot has frozen multiple times.

[Justin Fan]

Created attachment 366124 [details]
Patch

[Justin Fan]

Created attachment 366126 [details]
Patch

[Justin Fan]

Created attachment 366201 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 366201 [details]
Patch

Clearing flags on attachment: 366201

Committed r243627: <https://trac.webkit.org/changeset/243627>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.