196106 – Change macosx() to macos() in WK_API... and JSC_API... macros.

RESOLVED FIXED 196106

Change macosx() to macos() in WK_API... and JSC_API... macros.

https://bugs.webkit.org/show_bug.cgi?id=196106

Summary Change macosx() to macos() in WK_API... and JSC_API... macros.

Timothy Hatcher

Reported 2019-03-21 12:52:51 PDT

Our supported platforms should all work with the suggested macos() macro now.

Attachments
Patch (334.69 KB, patch) 2019-03-21 13:06 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (335.71 KB, patch) 2019-03-21 15:46 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2019-03-21 13:06:11 PDT Comment hidden (obsolete)

Created attachment 365599 [details] Patch

EWS Watchlist

Comment 2 2019-03-21 13:08:43 PDT Comment hidden (obsolete)

Attachment 365599 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSTypedArray.h:48: The parameter name "arrayType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:63: The parameter name "arrayType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:63: The parameter name "bytesDeallocator" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:74: The parameter name "arrayType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:87: The parameter name "arrayType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:98: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:108: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:118: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:128: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:138: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:154: The parameter name "bytesDeallocator" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:164: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:174: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRefInternal.h:53: The parameter name "runLoop" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSBasePrivate.h:46: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRef.h:64: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRef.h:71: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRef.h:100: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:94: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:106: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "attributes" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:131: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:149: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:54: JSC_API_AVAILABLE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/API/JSValueRef.h:172: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:181: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:191: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:282: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:293: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRefPrivate.h:88: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRefPrivate.h:88: The parameter name "callback" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRefPrivate.h:95: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 34 in 139 files If any of these errors are false positives, please file a bug against check-webkit-style.

Timothy Hatcher

Comment 3 2019-03-21 14:19:14 PDT Comment hidden (obsolete)

EWS failures are odd. Maybe the patch is too big. Builds fix locally.

Timothy Hatcher

Comment 4 2019-03-21 15:46:13 PDT

Created attachment 365631 [details] Patch

EWS Watchlist

Comment 5 2019-03-21 15:48:24 PDT Comment hidden (obsolete)

Attachment 365631 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSTypedArray.h:48: The parameter name "arrayType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:63: The parameter name "arrayType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:63: The parameter name "bytesDeallocator" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:74: The parameter name "arrayType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:87: The parameter name "arrayType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:98: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:108: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:118: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:128: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:138: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:154: The parameter name "bytesDeallocator" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:164: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSTypedArray.h:174: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRefInternal.h:53: The parameter name "runLoop" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSBasePrivate.h:46: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRef.h:64: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRef.h:71: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRef.h:100: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:94: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:106: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "attributes" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:131: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:149: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:54: JSC_API_AVAILABLE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/API/JSValueRef.h:172: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:181: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:191: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:282: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSValueRef.h:293: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRefPrivate.h:88: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRefPrivate.h:88: The parameter name "callback" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSContextRefPrivate.h:95: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 34 in 140 files If any of these errors are false positives, please file a bug against check-webkit-style.

Blaze Burg

Comment 6 2019-03-22 08:18:46 PDT

Comment on attachment 365631 [details] Patch rs=me

WebKit Commit Bot

Comment 7 2019-03-22 08:45:21 PDT

Comment on attachment 365631 [details] Patch Clearing flags on attachment: 365631 Committed r243376: <https://trac.webkit.org/changeset/243376>

WebKit Commit Bot

Comment 8 2019-03-22 08:45:22 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2019-03-22 08:47:18 PDT

<rdar://problem/49155012>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebKit Misc.

Assignee

Timothy Hatcher

Reported

2019-03-21 12:52 PDT

Modified

2019-03-22 08:47 PDT History

CC List

12 users Show

URL

Keywords InRadar

Depends on

Blocks