RESOLVED FIXED 196098
[JSC] Fix JSC build with newer ICU 
https://bugs.webkit.org/show_bug.cgi?id=196098
Summary [JSC] Fix JSC build with newer ICU
Yusuke Suzuki
Reported 2019-03-21 11:42:37 PDT
[JSC] Fix JSC build with newer ICU
Attachments
Patch (2.84 KB, patch)
2019-03-21 11:45 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-03-21 11:45:46 PDT
Created attachment 365580 [details] Patch
Yusuke Suzuki
Comment 2 2019-03-21 11:46:25 PDT
<rdar://problem/49113565>
Keith Miller
Comment 3 2019-03-21 11:49:56 PDT
Comment on attachment 365580 [details] Patch Would we rather be forced to to handle new cases? Maybe debug builds shouldn't have the default?
Yusuke Suzuki
Comment 4 2019-03-21 11:56:18 PDT
(In reply to Keith Miller from comment #3) > Comment on attachment 365580 [details] > Patch > > Would we rather be forced to to handle new cases? Maybe debug builds > shouldn't have the default? I think that "default" is OK here. This is because newly added fields are not handled in ECMAScript until it is specified in the ECMA402 spec. If we do not use "default" clause here, we will notice that a new enum field is added in ICU side. But it does not mean we should handle it at that time. When we handle it, we will see the proposal/spec and add it here anyway.
Keith Miller
Comment 5 2019-03-21 11:58:57 PDT
(In reply to Yusuke Suzuki from comment #4) > (In reply to Keith Miller from comment #3) > > Comment on attachment 365580 [details] > > Patch > > > > Would we rather be forced to to handle new cases? Maybe debug builds > > shouldn't have the default? > > I think that "default" is OK here. This is because newly added fields are > not handled in ECMAScript until it is specified in the ECMA402 spec. > If we do not use "default" clause here, we will notice that a new enum field > is added in ICU side. > But it does not mean we should handle it at that time. > When we handle it, we will see the proposal/spec and add it here anyway. Sounds good. r=me
Yusuke Suzuki
Comment 6 2019-03-21 12:09:16 PDT
Committed r243311: <https://trac.webkit.org/changeset/243311>
Note You need to log in before you can comment on or make changes to this bug.