RESOLVED FIXED 196088
Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing 
https://bugs.webkit.org/show_bug.cgi?id=196088
Summary Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is ...
Timothy Hatcher
Reported 2019-03-21 10:26:39 PDT
"WK_MAC_TBA is neither a version number nor WK_IOS_TBA" That statement is true, it is not a number nor WK_IOS_TBA — nothing to see here. It sounds (at a glance) like it is expecting only a number — since macosx(WK_MAC_TBA) was also used on the same line. The missing part is this is about the WK_MAC_TBA being used in the ios() macro. An error more like would help: "ios(WK_MAC_TBA) is invalid; expected WK_IOS_TBA or a number"
Attachments
Patch (6.68 KB, patch)
2019-03-21 11:19 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2019-03-21 11:19:43 PDT
Created attachment 365575 [details] Patch
Blaze Burg
Comment 2 2019-03-21 11:26:20 PDT
Comment on attachment 365575 [details] Patch r=mews
Timothy Hatcher
Comment 3 2019-03-21 11:30:43 PDT
webkitpy failures are 3 other tests.
WebKit Commit Bot
Comment 4 2019-03-21 11:57:14 PDT
Comment on attachment 365575 [details] Patch Clearing flags on attachment: 365575 Committed r243308: <https://trac.webkit.org/changeset/243308>
WebKit Commit Bot
Comment 5 2019-03-21 11:57:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-03-21 11:59:11 PDT
<rdar://problem/49117433>
Note You need to log in before you can comment on or make changes to this bug.