Bug 196087 - Remove the SVG tear off objects for SVGAngle, SVGAnimatedAngle and SVGAnimatedEnumeration
Summary: Remove the SVG tear off objects for SVGAngle, SVGAnimatedAngle and SVGAnimate...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
: 154141 (view as bug list)
Depends on:
Blocks: 191237
  Show dependency tree / graph
 
Reported: 2019-03-21 10:21 PDT by Said Abou-Hallawa
Modified: 2019-03-25 18:26 PDT (History)
10 users (show)

See Also:

Attachments
Patch (188.50 KB, patch)
2019-03-22 12:44 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (188.56 KB, patch)
2019-03-25 15:49 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (214.31 KB, patch)
2019-03-25 16:58 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-03-21 10:21:10 PDT 
This is part of removing the tear off objects of the SVG properties.
Comment 1 Radar WebKit Bug Importer 2019-03-21 14:01:17 PDT 
<rdar://problem/49122914>
Comment 2 Said Abou-Hallawa 2019-03-22 12:42:49 PDT 
*** Bug 154141 has been marked as a duplicate of this bug. ***
Comment 3 Said Abou-Hallawa 2019-03-22 12:44:32 PDT 
Created attachment 365754 [details]
Patch
Comment 4 EWS Watchlist 2019-03-22 12:46:51 PDT 
Attachment 365754 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/properties/SVGAnimatedDecoratedProperty.h:33:  Failed to find complete declaration of class DecoratedProperty  [build/class] [5]
Total errors found: 1 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Simon Fraser (smfr) 2019-03-25 12:56:55 PDT 
Comment on attachment 365754 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365754&action=review

> Source/WebCore/ChangeLog:44
> +        To get the mechanics of this change correctly, new accessors, animators

To get the mechanics of this change correct,
Comment 6 Said Abou-Hallawa 2019-03-25 15:49:12 PDT 
Created attachment 365911 [details]
Patch
Comment 7 EWS Watchlist 2019-03-25 15:52:27 PDT 
Attachment 365911 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/properties/SVGAnimatedDecoratedProperty.h:33:  Failed to find complete declaration of class DecoratedProperty  [build/class] [5]
Total errors found: 1 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Said Abou-Hallawa 2019-03-25 16:50:58 PDT 
I found out these files can be removed with this patch:

Source/WebCore/svg/properties/SVGAnimatedEnumerationPropertyTearOff.h
Source/WebCore/svg/properties/SVGAnimatedStaticPropertyTearOff.h
Source/WebCore/svg/properties/SVGStaticPropertyTearOff.h
Comment 9 Said Abou-Hallawa 2019-03-25 16:58:22 PDT 
Created attachment 365922 [details]
Patch
Comment 10 EWS Watchlist 2019-03-25 17:02:22 PDT 
Attachment 365922 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/properties/SVGAnimatedDecoratedProperty.h:33:  Failed to find complete declaration of class DecoratedProperty  [build/class] [5]
Total errors found: 1 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 WebKit Commit Bot 2019-03-25 18:26:18 PDT 
Comment on attachment 365922 [details]
Patch

Clearing flags on attachment: 365922

Committed r243478: <https://trac.webkit.org/changeset/243478>
Comment 12 WebKit Commit Bot 2019-03-25 18:26:20 PDT 
All reviewed patches have been landed.  Closing bug.