Bug 196085 – Remove the SVG tear off objects for SVGPathSeg, SVGPathSegList and SVGAnimatedPathSegList

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Said Abou-Hallawa]

This is part of removing the tear off objects of the SVG properties.

[Radar WebKit Bug Importer]

<rdar://problem/49121892>

[Said Abou-Hallawa]

Created attachment 365733 [details]
Patch

[EWS Watchlist]

Comment on attachment 365733 [details]
Patch

Attachment 365733 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11614662

New failing tests:
perf/svg-path-appenditem.html

[EWS Watchlist]

Created attachment 365751 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Simon Fraser (smfr)]

Comment on attachment 365733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365733&action=review

> Source/WebCore/svg/properties/SVGAnimatedPropertyAnimatorImpl.h:123
> +        return std::unique_ptr<SVGAnimatedPathSegListAnimator>(new SVGAnimatedPathSegListAnimator(attributeName, animated, animationMode, calcMode, isAccumulated, isAdditive));

make_unique<>

[Said Abou-Hallawa]

Created attachment 366080 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 366080 [details]
Patch

Clearing flags on attachment: 366080

Committed r243555: <https://trac.webkit.org/changeset/243555>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.