Bug 196078 - JSObject::putDirectIndexSlowOrBeyondVectorLength should check if indexIsSufficientlyBeyondLengthForSparseMap
Summary: JSObject::putDirectIndexSlowOrBeyondVectorLength should check if indexIsSuffi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-21 08:39 PDT by Tadeu Zagallo
Modified: 2019-03-21 10:42 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.04 KB, patch)
2019-03-21 08:42 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch for landing (3.20 KB, patch)
2019-03-21 09:52 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-03-21 08:39:55 PDT 
...
Comment 1 Tadeu Zagallo 2019-03-21 08:42:14 PDT 
Created attachment 365548 [details]
Patch
Comment 2 Tadeu Zagallo 2019-03-21 08:47:26 PDT 
<rdar://problem/35925380>
Comment 3 Mark Lam 2019-03-21 09:18:59 PDT 
Comment on attachment 365548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365548&action=review

r=me

> JSTests/ChangeLog:9
> +        * microbenchmarks/put-by-val-direct-large-index.js: Added.

Please record here what gains the microbenchmark shows.
Comment 4 Tadeu Zagallo 2019-03-21 09:52:14 PDT 
Created attachment 365561 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-03-21 10:42:46 PDT 
Comment on attachment 365561 [details]
Patch for landing

Clearing flags on attachment: 365561

Committed r243299: <https://trac.webkit.org/changeset/243299>
Comment 6 WebKit Commit Bot 2019-03-21 10:42:48 PDT 
All reviewed patches have been landed.  Closing bug.