Bug 196077 – We should pass minimumEffectiveDeviceWidth to web process on new page creation.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Yongjun Zhang]

If the page is using nativeWebpageParametersWithShrinkToFit as the default configuration, we should not force its initial scale to 1.

[Yongjun Zhang]

<rdar://problem/49108202>

[Yongjun Zhang]

Created attachment 365547 [details]
Ignore the initial scale.

[EWS Watchlist]

Comment on attachment 365547 [details]
Ignore the initial scale.

Attachment 365547 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11602696

New failing tests:
fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall.html
fast/viewport/ios/viewport-shrink-to-fit-on-new-navigation.html

[EWS Watchlist]

Created attachment 365605 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Yongjun Zhang]

Created attachment 366852 [details]
Patch.

[EWS Watchlist]

Attachment 366852 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:5889:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:5905:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Comment on attachment 366852 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=366852&action=review

r=me

> LayoutTests/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).

This goes before "Add a layout test..."

> Source/WebCore/page/ViewportConfiguration.cpp:180
> +    updateMinimumLayoutSize();

Could this be moved inside updateDefaultConfiguration() if it is needed whenever we update the default config?

> Source/WebKit/ChangeLog:12
> +        Reviewed by NOBODY (OOPS!).

Should come before the description.

> Source/WebKit/Shared/WebPageCreationParameters.h:151
> +    double viewportConfigurationMinimumEffectiveDeviceWidth;

Should really have a default value, to be safe.

> Tools/ChangeLog:12
> +        https://bugs.webkit.org/show_bug.cgi?id=196077

What's this?

> Tools/ChangeLog:13
> +        <rdar://problem/49108202>

What's this?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:5923
> +        EXPECT_EQ([width intValue], 1024);

1024 should go first.

[Yongjun Zhang]

Created attachment 366867 [details]
Add review comments and fix mac build failure.

[EWS Watchlist]

Attachment 366867 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:5889:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:5905:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 366867 [details]
Add review comments and fix mac build failure.

Clearing flags on attachment: 366867

Committed r243961: <https://trac.webkit.org/changeset/243961>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49665406>