Bug 196075 – All PointerEvent.isTrusted is always false.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

Created attachment 365543 [details]
please ⌥⌘C、The value of PointerEent.isTrusted is displayed

environment:
* macOS Mojave 10.14.3
* Safari Technology Preview: Release 78 (Safari 12.2, WebKit 14608.1.9.1)
* menu -> Develop -> Experimental Features -> ☑Pointer Events

All PointerEvent.isTrusted values ​​are always false.
This can not really determine if the user has 'pointerdown'.
Can Trusted PointerEvent.isTrusted tobe true?

[Radar WebKit Bug Importer]

<rdar://problem/49158778>

[Antoine Quint]

Alas, the MouseEvent constructor we're using does not take in IsTrusted, so we'll need to move to a constructor that does, and the one available does not accepted an initializer.

[Antoine Quint]

This only affects macOS, on iOS we're overriding MouseEvent constructors that already allow for IsTrusted to be passed in and where we always pass IsTrusted::Yes.

[Antoine Quint]

Created attachment 366161 [details]
Patch

[Chris Dumez]

Comment on attachment 366161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366161&action=review

r=me with comments.

> Source/WebCore/dom/PointerEvent.cpp:87
> +Ref<PointerEvent> PointerEvent::createPointerCancelEvent(PointerID pointerId, String pointerType)

const String& or maybe const AtomicString&.

> Source/WebCore/dom/PointerEvent.cpp:115
> +PointerEvent::PointerEvent(const AtomicString& type, CanBubble canBubble, IsCancelable isCancelable, IsComposed isComposed, PointerID pointerId, String pointerType)

const String& or const AtomicString&, not String.

> Source/WebCore/dom/PointerEvent.h:76
> +    static Ref<PointerEvent> createPointerCancelEvent(PointerID, String pointerType);

const String& or const AtomicString&.

[Antoine Quint]

Committed r243645: <https://trac.webkit.org/changeset/243645>