Bug 196074 - [ews-build] Update queues configurations
Summary: [ews-build] Update queues configurations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-21 06:15 PDT by Aakash Jain
Modified: 2019-03-21 15:02 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.81 KB, patch)
2019-03-21 06:18 PDT, Aakash Jain
dewei_zhu: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-03-21 06:15:20 PDT
Update queues configurations (e.g: from iOS11 -> iOS12, re-assigning bots etc.)
Comment 1 Aakash Jain 2019-03-21 06:18:01 PDT
Created attachment 365541 [details]
Patch
Comment 2 Aakash Jain 2019-03-21 06:19:58 PDT
Comment on attachment 365541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365541&action=review

> Tools/BuildSlaveSupport/ews-build/config.json:438
> +      "name": "disabled",

Assigned few queues which will not be in production initially to another scheduler. This scheduler wouldn't be triggered automatically.
Comment 3 Ryan Haddad 2019-03-21 11:12:04 PDT
Comment on attachment 365541 [details]
Patch

The change looks good to me.
Comment 4 dewei_zhu 2019-03-21 14:37:30 PDT
Comment on attachment 365541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365541&action=review

> Tools/ChangeLog:7
> +

I see some platforms moving from iOS 11 to 12. It would be much easier to read this change if you could leave a high level description of this change.

> Tools/BuildSlaveSupport/ews-build/config.json:233
> +      "name": "ews170",

Some of the bots are not used in this patch yet, correct?
Comment 5 Aakash Jain 2019-03-21 14:51:15 PDT
> Some of the bots are not used in this patch yet, correct?
Yeah, added some bots here which would be configured in future in order to make it easier to configure them.
Comment 6 Aakash Jain 2019-03-21 15:00:55 PDT
Committed r243334: <https://trac.webkit.org/changeset/243334>
Comment 7 Radar WebKit Bug Importer 2019-03-21 15:01:37 PDT
<rdar://problem/49125839>
Comment 8 Aakash Jain 2019-03-21 15:02:15 PDT
> It would be much easier to read this change if you could leave a high level description of this change.
Updated ChangeLog before landing.