WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
196074
[ews-build] Update queues configurations
https://bugs.webkit.org/show_bug.cgi?id=196074
Summary
[ews-build] Update queues configurations
Aakash Jain
Reported
2019-03-21 06:15:20 PDT
Update queues configurations (e.g: from iOS11 -> iOS12, re-assigning bots etc.)
Attachments
Patch
(8.81 KB, patch)
2019-03-21 06:18 PDT
,
Aakash Jain
dewei_zhu: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2019-03-21 06:18:01 PDT
Created
attachment 365541
[details]
Patch
Aakash Jain
Comment 2
2019-03-21 06:19:58 PDT
Comment on
attachment 365541
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=365541&action=review
> Tools/BuildSlaveSupport/ews-build/config.json:438 > + "name": "disabled",
Assigned few queues which will not be in production initially to another scheduler. This scheduler wouldn't be triggered automatically.
Ryan Haddad
Comment 3
2019-03-21 11:12:04 PDT
Comment on
attachment 365541
[details]
Patch The change looks good to me.
dewei_zhu
Comment 4
2019-03-21 14:37:30 PDT
Comment on
attachment 365541
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=365541&action=review
> Tools/ChangeLog:7 > +
I see some platforms moving from iOS 11 to 12. It would be much easier to read this change if you could leave a high level description of this change.
> Tools/BuildSlaveSupport/ews-build/config.json:233 > + "name": "ews170",
Some of the bots are not used in this patch yet, correct?
Aakash Jain
Comment 5
2019-03-21 14:51:15 PDT
> Some of the bots are not used in this patch yet, correct?
Yeah, added some bots here which would be configured in future in order to make it easier to configure them.
Aakash Jain
Comment 6
2019-03-21 15:00:55 PDT
Committed
r243334
: <
https://trac.webkit.org/changeset/243334
>
Radar WebKit Bug Importer
Comment 7
2019-03-21 15:01:37 PDT
<
rdar://problem/49125839
>
Aakash Jain
Comment 8
2019-03-21 15:02:15 PDT
> It would be much easier to read this change if you could leave a high level description of this change.
Updated ChangeLog before landing.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug