Bug 196070 - Remove NavigatorContentUtils in WebCore/Modules
Summary: Remove NavigatorContentUtils in WebCore/Modules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-21 02:05 PDT by Gyuyoung Kim
Modified: 2019-03-25 01:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (98.24 KB, patch)
2019-03-21 02:29 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (98.84 KB, patch)
2019-03-21 02:46 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (97.85 KB, patch)
2019-03-24 20:42 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (97.85 KB, patch)
2019-03-24 21:54 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (97.83 KB, patch)
2019-03-24 23:36 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2019-03-21 02:05:18 PDT 
NavigatorContentUtils was to support the custom scheme spec - https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers. However, in WebKit side, no port has supported the feature in the WebKit layer after EFL port was removed. So there has been the only IDL implementation of the NavigatorContentUtils in WebCore. So let's remove the partial implementation in WebCore.
Comment 1 Gyuyoung Kim 2019-03-21 02:29:23 PDT 
Created attachment 365523 [details]
Patch
Comment 2 Gyuyoung Kim 2019-03-21 02:46:03 PDT 
Created attachment 365525 [details]
Patch
Comment 3 Gyuyoung Kim 2019-03-21 18:04:35 PDT 
Comment on attachment 365525 [details]
Patch

If there is any port which has been using this feature or will use it in the future, please let me know.
Comment 4 Alex Christensen 2019-03-22 10:09:36 PDT 
Comment on attachment 365525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365525&action=review

If we decide to implement or ship this, we can refer to the svn history.  If it's just dead code, let's remove it.

> Source/JavaScriptCore/ChangeLog:-138
> -        * Configurations/FeatureDefines.xcconfig:
> -

This should be left as it was.
Comment 5 Gyuyoung Kim 2019-03-24 20:04:49 PDT 
Comment on attachment 365525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365525&action=review

>> Source/JavaScriptCore/ChangeLog:-138
>> -
> 
> This should be left as it was.

Right. I did a mistake when I rebase this patch.
Comment 6 Gyuyoung Kim 2019-03-24 20:08:23 PDT 
> If we decide to implement or ship this, we can refer to the svn history.  If it's just dead code, let's remove it.

If someone wants to implement or ship this feature in the future, we can start to work after reverting this patch. But, as far as I know, nobody supports this feature in WebKit upstream ports now.
Comment 7 Gyuyoung Kim 2019-03-24 20:42:39 PDT 
Created attachment 365845 [details]
Patch for landing
Comment 8 Gyuyoung Kim 2019-03-24 21:54:18 PDT 
Created attachment 365847 [details]
Patch
Comment 9 Gyuyoung Kim 2019-03-24 23:36:02 PDT 
Created attachment 365852 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2019-03-25 01:07:20 PDT 
Comment on attachment 365852 [details]
Patch for landing

Clearing flags on attachment: 365852

Committed r243433: <https://trac.webkit.org/changeset/243433>
Comment 11 WebKit Commit Bot 2019-03-25 01:07:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-03-25 01:08:23 PDT 
<rdar://problem/49207736>