Bug 196068 - [JSCore][32-bit] Build failure after r243232
Summary: [JSCore][32-bit] Build failure after r243232
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pablo Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-21 01:13 PDT by Pablo Saavedra
Modified: 2019-03-21 04:08 PDT (History)
7 users (show)

See Also:


Attachments
patch (4.60 KB, patch)
2019-03-21 01:18 PDT, Pablo Saavedra
no flags Details | Formatted Diff | Diff
patch (4.62 KB, patch)
2019-03-21 02:56 PDT, Pablo Saavedra
no flags Details | Formatted Diff | Diff
patch (4.62 KB, patch)
2019-03-21 02:58 PDT, Pablo Saavedra
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Saavedra 2019-03-21 01:13:58 PDT
Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the JSC builds for WPE
Comment 1 Pablo Saavedra 2019-03-21 01:18:46 PDT
Created attachment 365516 [details]
patch
Comment 2 Pablo Saavedra 2019-03-21 01:33:54 PDT
CodeOrigin changes and now is defined as a class. 


```
-struct CodeOrigin {
-    static const unsigned invalidBytecodeIndex = UINT_MAX;
-    
-    // Bytecode offset that you'd use to re-execute this instruction, and the
-    // bytecode index of the bytecode instruction that produces some result that
-    // you're interested in (used for mapping Nodes whose values you're using
-    // to bytecode instructions that have the appropriate value profile).
-    unsigned bytecodeIndex;
-    
-    InlineCallFrame* inlineCallFrame;
-    
+class CodeOrigin {
+public:
...
```

... bytecodeIndex is now defined as function


```
...
+    unsigned bytecodeIndex() const
+    {
+#if CPU(ADDRESS64)
+        if (!isSet())
+            return s_invalidBytecodeIndex;
+        if (UNLIKELY(isOutOfLine()))
+            return outOfLineCodeOrigin()->bytecodeIndex;
+        return m_compositeValue >> (64 - s_freeBitsAtTop);
+#else
+        return m_bytecodeIndex;
+#endif
+    }

```
Comment 3 Mark Lam 2019-03-21 01:51:41 PDT
(In reply to Pablo Saavedra from comment #0)
> Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the
> JSC builds for WPE

Can you please provide a dump of the build failure?  According to the WPE EWS on https://bugs.webkit.org/show_bug.cgi?id=195928, it seemed to build fine.
Comment 4 Mark Lam 2019-03-21 01:53:35 PDT
(In reply to Mark Lam from comment #3)
> (In reply to Pablo Saavedra from comment #0)
> > Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the
> > JSC builds for WPE
> 
> Can you please provide a dump of the build failure?  According to the WPE
> EWS on https://bugs.webkit.org/show_bug.cgi?id=195928, it seemed to build
> fine.

OK, I see what the issue is.  It's not a WPE build issue, but a 32-bit build issue.
Comment 5 Mark Lam 2019-03-21 01:54:41 PDT
Comment on attachment 365516 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365516&action=review

r=me with fixed title change.

> Source/JavaScriptCore/ChangeLog:3
> +        Build failure after r243232

Please retitle this bug to say "32-bit build failure after r243232".
Comment 6 Pablo Saavedra 2019-03-21 02:22:05 PDT
(In reply to Mark Lam from comment #5)
> Comment on attachment 365516 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365516&action=review
> 
> r=me with fixed title change.
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        Build failure after r243232
> 
> Please retitle this bug to say "32-bit build failure after r243232".

+1
Comment 7 Pablo Saavedra 2019-03-21 02:25:53 PDT
(In reply to Mark Lam from comment #4)
> (In reply to Mark Lam from comment #3)
> > (In reply to Pablo Saavedra from comment #0)
> > > Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the
> > > JSC builds for WPE
> > 
> > Can you please provide a dump of the build failure?  According to the WPE
> > EWS on https://bugs.webkit.org/show_bug.cgi?id=195928, it seemed to build
> > fine.
> 
> OK, I see what the issue is.  It's not a WPE build issue, but a 32-bit build
> issue.

Ahh, yes. I expressed myself poorly. I saw the problem in the ARMv7 JSCore bots for WPE https://build.webkit.org/waterfall?category=misc but probably appeared in other 32-bits bots as well.
Comment 8 Mark Lam 2019-03-21 02:50:53 PDT
Please fix the title in the ChangeLog as well.
Comment 9 Pablo Saavedra 2019-03-21 02:56:25 PDT
Created attachment 365527 [details]
patch
Comment 10 Pablo Saavedra 2019-03-21 02:58:41 PDT
Created attachment 365528 [details]
patch
Comment 11 Pablo Saavedra 2019-03-21 02:59:42 PDT
(In reply to Mark Lam from comment #8)
> Please fix the title in the ChangeLog as well.

done.
Comment 12 WebKit Commit Bot 2019-03-21 03:36:03 PDT
Comment on attachment 365528 [details]
patch

Clearing flags on attachment: 365528

Committed r243286: <https://trac.webkit.org/changeset/243286>
Comment 13 WebKit Commit Bot 2019-03-21 03:36:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2019-03-21 04:08:44 PDT
<rdar://problem/49102907>