Bug 196068 – [JSCore][32-bit] Build failure after r243232

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Pablo Saavedra]

Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the JSC builds for WPE

[Pablo Saavedra]

Created attachment 365516 [details]
patch

[Pablo Saavedra]

CodeOrigin changes and now is defined as a class. 


```
-struct CodeOrigin {
-    static const unsigned invalidBytecodeIndex = UINT_MAX;
-    
-    // Bytecode offset that you'd use to re-execute this instruction, and the
-    // bytecode index of the bytecode instruction that produces some result that
-    // you're interested in (used for mapping Nodes whose values you're using
-    // to bytecode instructions that have the appropriate value profile).
-    unsigned bytecodeIndex;
-    
-    InlineCallFrame* inlineCallFrame;
-    
+class CodeOrigin {
+public:
...
```

... bytecodeIndex is now defined as function


```
...
+    unsigned bytecodeIndex() const
+    {
+#if CPU(ADDRESS64)
+        if (!isSet())
+            return s_invalidBytecodeIndex;
+        if (UNLIKELY(isOutOfLine()))
+            return outOfLineCodeOrigin()->bytecodeIndex;
+        return m_compositeValue >> (64 - s_freeBitsAtTop);
+#else
+        return m_bytecodeIndex;
+#endif
+    }

```

[Mark Lam]

(In reply to Pablo Saavedra from comment #0)
> Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the
> JSC builds for WPE

Can you please provide a dump of the build failure?  According to the WPE EWS on https://bugs.webkit.org/show_bug.cgi?id=195928, it seemed to build fine.

[Mark Lam]

(In reply to Mark Lam from comment #3)
> (In reply to Pablo Saavedra from comment #0)
> > Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the
> > JSC builds for WPE
> 
> Can you please provide a dump of the build failure?  According to the WPE
> EWS on https://bugs.webkit.org/show_bug.cgi?id=195928, it seemed to build
> fine.

OK, I see what the issue is.  It's not a WPE build issue, but a 32-bit build issue.

[Mark Lam]

Comment on attachment 365516 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365516&action=review

r=me with fixed title change.

> Source/JavaScriptCore/ChangeLog:3
> +        Build failure after r243232

Please retitle this bug to say "32-bit build failure after r243232".

[Pablo Saavedra]

(In reply to Mark Lam from comment #5)
> Comment on attachment 365516 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365516&action=review
> 
> r=me with fixed title change.
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        Build failure after r243232
> 
> Please retitle this bug to say "32-bit build failure after r243232".

+1

[Pablo Saavedra]

(In reply to Mark Lam from comment #4)
> (In reply to Mark Lam from comment #3)
> > (In reply to Pablo Saavedra from comment #0)
> > > Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the
> > > JSC builds for WPE
> > 
> > Can you please provide a dump of the build failure?  According to the WPE
> > EWS on https://bugs.webkit.org/show_bug.cgi?id=195928, it seemed to build
> > fine.
> 
> OK, I see what the issue is.  It's not a WPE build issue, but a 32-bit build
> issue.

Ahh, yes. I expressed myself poorly. I saw the problem in the ARMv7 JSCore bots for WPE https://build.webkit.org/waterfall?category=misc but probably appeared in other 32-bits bots as well.

[Mark Lam]

Please fix the title in the ChangeLog as well.

[Pablo Saavedra]

Created attachment 365527 [details]
patch

[Pablo Saavedra]

Created attachment 365528 [details]
patch

[Pablo Saavedra]

(In reply to Mark Lam from comment #8)
> Please fix the title in the ChangeLog as well.

done.

[WebKit Commit Bot]

Comment on attachment 365528 [details]
patch

Clearing flags on attachment: 365528

Committed r243286: <https://trac.webkit.org/changeset/243286>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49102907>