Bug 196058 – Add an internal feature flag to disable the -webkit-overflow-scrolling CSS property

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Add an internal feature flag to disable the -webkit-overflow-scrolling CSS property

[Simon Fraser (smfr)]

Created attachment 365492 [details]
Patch

[Simon Fraser (smfr)]

<rdar://problem/49078202>

[EWS Watchlist]

Comment on attachment 365492 [details]
Patch

Attachment 365492 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11594807

New failing tests:
http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html

[EWS Watchlist]

Created attachment 365517 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Simon Fraser (smfr)]

Created attachment 365550 [details]
Patch

[Antti Koivisto]

Comment on attachment 365550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365550&action=review

r=me with change to const CSSParserContext&.

> Source/WebCore/css/parser/CSSParserFastPaths.cpp:523
> +bool CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyID propertyId, CSSValueID valueID, CSSParserMode parserMode, const CSSParserContext* context)

How would the caller know when to provide this context? Please make it a reference and like everywhere else it is used.

> Source/WebCore/css/parser/CSSParserFastPaths.cpp:810
> +        WTFLogAlways("Parsing CSSPropertyWebkitOverflowScrolling; enabled %d", context && context->legacyOverflowScrollingTouchEnabled);

Please don't leave spammy logging in.

[Simon Fraser (smfr)]

(In reply to Antti Koivisto from comment #6)
> Comment on attachment 365550 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365550&action=review
> 
> r=me with change to const CSSParserContext&.

There's a caller (inspector code) that doesn't have access to a CSSParserContext.

[Antti Koivisto]

> There's a caller (inspector code) that doesn't have access to a
> CSSParserContext.

There is strictCSSParserContext() global for cases where a real context (with base urls etc) is not needed.

[Simon Fraser (smfr)]

Created attachment 365583 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 365595 [details]
Patch

[Simon Fraser (smfr)]

https://trac.webkit.org/r243318

[Alex Christensen]

Comment on attachment 365595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365595&action=review

> Source/WebCore/css/parser/CSSParserFastPaths.cpp:811
> +            return nullptr;

return false
:(