196047 – Web Inspector: create CommandLineAPIHost lazily like the other agents

Bug 196047 - Web Inspector: create CommandLineAPIHost lazily like the other agents

Summary: Web Inspector: create CommandLineAPIHost lazily like the other agents

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (show other bugs)
Version:	WebKit Nightly Build
Hardware:	All All

Importance:	P2 Normal
Assignee:	Devin Rousso

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2019-03-20 17:50 PDT by Devin Rousso
Modified:	2019-06-06 16:31 PDT (History)
CC List:	12 users (show)

See Also:

Attachments
Patch (9.36 KB, patch) 2019-05-05 23:06 PDT, Devin Rousso	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews101 for mac-highsierra (922.00 KB, application/zip) 2019-05-05 23:56 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (1001.17 KB, application/zip) 2019-05-06 00:04 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews215 for win-future (8.78 MB, application/zip) 2019-05-06 00:11 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-highsierra (955.91 KB, application/zip) 2019-05-06 00:17 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (681.21 KB, application/zip) 2019-05-06 00:31 PDT, EWS Watchlist	no flags	Details
Patch (9.37 KB, patch) 2019-05-13 12:06 PDT, Devin Rousso	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews102 for mac-highsierra (900.50 KB, application/zip) 2019-05-13 12:59 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (942.63 KB, application/zip) 2019-05-13 13:06 PDT, EWS Watchlist	no flags	Details
Patch (8.09 KB, patch) 2019-05-13 13:20 PDT, Devin Rousso	no flags	Details \| Formatted Diff \| Diff
Patch (8.08 KB, patch) 2019-05-13 17:53 PDT, Devin Rousso	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews103 for mac-highsierra (931.50 KB, application/zip) 2019-05-13 18:45 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (959.78 KB, application/zip) 2019-05-13 18:51 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (1.12 MB, application/zip) 2019-05-13 18:54 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-highsierra (945.90 KB, application/zip) 2019-05-13 19:05 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews212 for win-future (7.94 MB, application/zip) 2019-05-13 21:17 PDT, EWS Watchlist	no flags	Details
Patch (9.57 KB, patch) 2019-05-15 01:07 PDT, Devin Rousso	no flags	Details \| Formatted Diff \| Diff
Patch (9.57 KB, patch) 2019-05-15 04:04 PDT, Devin Rousso	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (17) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Devin Rousso 2019-03-20 17:50:19 PDT

We don't need the command line API to be available until we connect a frontend.

Comment 1 Radar WebKit Bug Importer 2019-03-20 17:50:36 PDT

<rdar://problem/49087835>

Comment 2 Devin Rousso 2019-05-05 23:06:39 PDT

Created attachment 369100 [details]
Patch

Comment 3 EWS Watchlist 2019-05-05 23:56:50 PDT Comment hidden (obsolete)

Comment on attachment 369100 [details]
Patch

Attachment 369100 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12109144

Number of test failures exceeded the failure limit.

Comment 4 EWS Watchlist 2019-05-05 23:56:52 PDT Comment hidden (obsolete)

Created attachment 369102 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

Comment 5 EWS Watchlist 2019-05-06 00:04:51 PDT Comment hidden (obsolete)

Comment on attachment 369100 [details]
Patch

Attachment 369100 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12109149

Number of test failures exceeded the failure limit.

Comment 6 EWS Watchlist 2019-05-06 00:04:53 PDT Comment hidden (obsolete)

Created attachment 369104 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

Comment 7 EWS Watchlist 2019-05-06 00:11:00 PDT Comment hidden (obsolete)

Comment on attachment 369100 [details]
Patch

Attachment 369100 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12109225

Number of test failures exceeded the failure limit.

Comment 8 EWS Watchlist 2019-05-06 00:11:02 PDT Comment hidden (obsolete)

Created attachment 369105 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Comment 9 EWS Watchlist 2019-05-06 00:17:03 PDT Comment hidden (obsolete)

Comment on attachment 369100 [details]
Patch

Attachment 369100 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12109142

Number of test failures exceeded the failure limit.

Comment 10 EWS Watchlist 2019-05-06 00:17:05 PDT Comment hidden (obsolete)

Created attachment 369107 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6

Comment 11 EWS Watchlist 2019-05-06 00:31:04 PDT Comment hidden (obsolete)

Comment on attachment 369100 [details]
Patch

Attachment 369100 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12109223

Number of test failures exceeded the failure limit.

Comment 12 EWS Watchlist 2019-05-06 00:31:05 PDT Comment hidden (obsolete)

Created attachment 369109 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.4

Comment 13 Devin Rousso 2019-05-13 12:06:25 PDT

Created attachment 369759 [details]
Patch

Rebase, to see if the test failures are actually caused by this change.

Comment 14 EWS Watchlist 2019-05-13 12:59:00 PDT Comment hidden (obsolete)

Comment on attachment 369759 [details]
Patch

Attachment 369759 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12179789

Number of test failures exceeded the failure limit.

Comment 15 EWS Watchlist 2019-05-13 12:59:02 PDT Comment hidden (obsolete)

Created attachment 369767 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6

Comment 16 EWS Watchlist 2019-05-13 13:05:58 PDT Comment hidden (obsolete)

Comment on attachment 369759 [details]
Patch

Attachment 369759 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12179818

Number of test failures exceeded the failure limit.

Comment 17 EWS Watchlist 2019-05-13 13:06:00 PDT Comment hidden (obsolete)

Created attachment 369768 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

Comment 18 Devin Rousso 2019-05-13 13:20:16 PDT

Created attachment 369771 [details]
Patch

Comment 19 Devin Rousso 2019-05-13 17:53:27 PDT

Created attachment 369805 [details]
Patch

Comment 20 EWS Watchlist 2019-05-13 18:45:44 PDT Comment hidden (obsolete)

Comment on attachment 369805 [details]
Patch

Attachment 369805 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12183265

Number of test failures exceeded the failure limit.

Comment 21 EWS Watchlist 2019-05-13 18:45:46 PDT Comment hidden (obsolete)

Created attachment 369806 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6

Comment 22 EWS Watchlist 2019-05-13 18:51:43 PDT Comment hidden (obsolete)

Comment on attachment 369805 [details]
Patch

Attachment 369805 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12183266

Number of test failures exceeded the failure limit.

Comment 23 EWS Watchlist 2019-05-13 18:51:45 PDT Comment hidden (obsolete)

Created attachment 369807 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

Comment 24 EWS Watchlist 2019-05-13 18:54:15 PDT Comment hidden (obsolete)

Comment on attachment 369805 [details]
Patch

Attachment 369805 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12183156

Number of test failures exceeded the failure limit.

Comment 25 EWS Watchlist 2019-05-13 18:54:17 PDT Comment hidden (obsolete)

Created attachment 369808 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.4

Comment 26 EWS Watchlist 2019-05-13 19:05:09 PDT Comment hidden (obsolete)

Comment on attachment 369805 [details]
Patch

Attachment 369805 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12183257

Number of test failures exceeded the failure limit.

Comment 27 EWS Watchlist 2019-05-13 19:05:11 PDT Comment hidden (obsolete)

Created attachment 369809 [details]
Archive of layout-test-results from ews116 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-highsierra  Platform: Mac OS X 10.13.6

Comment 28 EWS Watchlist 2019-05-13 21:17:06 PDT Comment hidden (obsolete)

Comment on attachment 369805 [details]
Patch

Attachment 369805 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12184291

Number of test failures exceeded the failure limit.

Comment 29 EWS Watchlist 2019-05-13 21:17:09 PDT Comment hidden (obsolete)

Created attachment 369818 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Comment 30 Devin Rousso 2019-05-15 01:07:44 PDT

Created attachment 369937 [details]
Patch

Comment 31 Devin Rousso 2019-05-15 04:04:01 PDT

Created attachment 369945 [details]
Patch

Comment 32 WebKit Commit Bot 2019-06-06 16:31:46 PDT

Comment on attachment 369945 [details]
Patch

Clearing flags on attachment: 369945

Committed r246177: <https://trac.webkit.org/changeset/246177>

Comment 33 WebKit Commit Bot 2019-06-06 16:31:48 PDT

All reviewed patches have been landed.  Closing bug.